Skip to content

Addressing issue #417. - #418

Open
jlinenkohl wants to merge 1 commit into
Azure:mainfrom
jlinenkohl:main
Open

Addressing issue #417.#418
jlinenkohl wants to merge 1 commit into
Azure:mainfrom
jlinenkohl:main

Conversation

@jlinenkohl

Copy link
Copy Markdown
Contributor

This PR closes #417

The changes in this PR are as follows:

  • Removed TryBalanceVmsPerHost from ClusterDrsConfigInfo spec when applying custom DRS settings via Set-CustomDRS.
  • Also added some vscode specific .gitignore entries.

I have read the contributor guidelines and have completed the following:

  • [ x] Formatted the code using VSCode default formatter for PowerShell.
  • [ x] Tested the code end-to-end against an SDDC.
  • [ x] Documented the functions using standard PowerShell markup and applied AVSAttribute to newly exported functions.

- Removed TryBalanceVmsPerHost from ClusterDrsConfigInfo spec when applying custom DRS settings via Set-CustomDRS.

Azure#417

- Also added some vscode specific .gitignore entries.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@jlinenkohl

Copy link
Copy Markdown
Contributor Author

jlinenkohl please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set-CustomDRS is setting TryBalanceVmsPerHost to 0 and it shouldn't

1 participant