feat(Barretenberg): acir<->bb tool: HONK opcode validator - #25006
Open
DanielKotov wants to merge 8 commits into
Open
feat(Barretenberg): acir<->bb tool: HONK opcode validator#25006DanielKotov wants to merge 8 commits into
DanielKotov wants to merge 8 commits into
Conversation
Extract HONK opcode validators and wire StaticAnalyzerAcir HONK case onto dk/acir_recursion_constraints for reviewable per-opcode stacking.
Unqualified GateKind:: breaks clang20 compile after gate_selector_for migration; use bb::GateKind consistently.
Call validate_commitment_receive_fingerprint via OinkVerifierValidation (moved out of recursion_helpers on the base branch). Add missing chonk_acir_test_utils.hpp so the shared test target compiles.
Use poseidon2_helpers block accessors and OinkVerifierValidation SINGLE_COMMITMENT_* fingerprints so HONK builds against the post-next helper layout on dk/acir_recursion_constraints.
HONK validators were authored against the agent1 helper layout (recursion_helpers::SINGLE_COMMITMENT_*, collect_real_witness_gates_in_block, validate_commitment_receive_fingerprint). Bring that helper onto the HONK branch so the validators compile without endless OinkVerifierValidation aliases.
With agent1 helper restored, call SINGLE_COMMITMENT_* and validate_commitment_receive_fingerprint via recursion_helpers again.
Mega merged poseidon2_external/internal; use accessors so the transplanted agent1 helper compiles on the current execution-trace layout.
… HONK Keep the base helper (CHONK needs ULTRA_BLOCK_*), and re-export the fingerprint helpers HONK validators call via recursion_helpers::.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces validator for ACIR's HONK opcode