feat(Barretenberg): acir<->bb tool: HN:FINAL opcode validator - #25003
Open
DanielKotov wants to merge 2 commits into
Open
feat(Barretenberg): acir<->bb tool: HN:FINAL opcode validator#25003DanielKotov wants to merge 2 commits into
DanielKotov wants to merge 2 commits into
Conversation
HNFinalValidation.hpp self-nests under namespace HNVerification so it no longer depends on hypernova_verification.hpp textually including it; includes hypernova_verification.hpp and recursion_constraints_helper.hpp directly instead. validate_hn_hiding, HNHidingValidationResult, and the HN_HIDING_* extension-kernel constants move here from hypernova_verification.hpp (see dk/hn_family_common) since they are FINAL-only. Updates boomerang_hn_final_recursion.test.cpp call sites from HNVerification::validate_hn_hiding to HNVerification::HNFinalValidation::validate_hn_hiding.
Previously reached HNVerification::HNFinalValidation transitively via hypernova_verification.hpp's textual include (removed in dk/hn_family_common when the file was decoupled from opcode headers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for HN::FINAL opcode validator