feat: merge-train/fairies#24994
Open
AztecBot wants to merge 9 commits into
Open
Conversation
…om yarn-project/constants (#24730) Adds remake-constants scripts to barretenberg and l1-contracts so they control which constants are generated for themselves. Conversely removes those from `yarn-projects/constants`. Removes generated constant files from git, regenerating them on build based on constants.nr as the source of truth. Closes F-817, F-813, F-818, F-820, F-816
AztecBot
requested review from
IlyasRidhuan,
MirandaWood and
just-mitch
as code owners
July 27, 2026 10:19
- Make constant output selection configurable via a simple `json` file - Make constant consumers maintain the list of constants they consume (input to the generator) Decouples knowledge of specific consumers from the constants-codegen itself
Embeds constants.nr as default input to the constants-codegen package, and adds some bash conveniences to encapsulate references to it, to make it easier to flip the switch when the actual repo split is executed. Closes F-822, F-823 Co-authored-by: Facundo <fcarreiro@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
With this change, these files are served instead through the protocol contracts package (where they already existed). I changed the generation of noir-contracts.js so that only non-protocol non-test contracts go there, so it is now ready for the noir side of things to also be split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: remove constant generation call for languages other than TS from yarn-project/constants (#24730)
chore: consumer driven constant selection (#24734)
chore: turn constants codegen into a formal dependency (#24958)
chore!: move protocol contracts out of noir-contracts.js (#24998)
END_COMMIT_OVERRIDE