test: fix acir components debug fixture - #24986
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
AztecBot
added
ci-barretenberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcirComponentsCheckTest.DetectsUnconstrainedWitnesses.builder.real_variable_index.resize(9)mutation with a valid smaller synthesized circuit checked against a larger ACIR circuit.UNCONSTRAINEDerror path without breaking the static analyzer's builder invariants under_GLIBCXX_DEBUG.Root Cause
The failing test simulated a missing circuit witness by shrinking
builder.real_variable_indexaftercreate_circuit. The builder's gates still referenced the original witness indices, so libstdc++ debug mode aborted inside the static analyzer while converting gate variables throughreal_variable_index[10]on a vector of size 9. Release builds did not catch that out-of-bounds access.Testing
cmake --preset debugcmake --build build-debug --target acir_components_check_testsNATIVE_PRESET=debug barretenberg/cpp/scripts/run_test.sh acir_components_check_tests AcirComponentsCheckTest.DetectsUnconstrainedWitnessesNATIVE_PRESET=debug barretenberg/cpp/scripts/run_test.sh acir_components_check_tests '*'Created by claudebox · group:
slackbot· Slack thread