Skip to content

fix(bb): repair acir components debug regression test - #24979

Draft
AztecBot wants to merge 1 commit into
nextfrom
cb/fix-bb-debug-acir-components-test
Draft

fix(bb): repair acir components debug regression test#24979
AztecBot wants to merge 1 commit into
nextfrom
cb/fix-bb-debug-acir-components-test

Conversation

@AztecBot

@AztecBot AztecBot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes the canonical nightly debug failure in run 30190406234, where AcirComponentsCheckTest.DetectsUnconstrainedWitnesses aborted under _GLIBCXX_DEBUG with an out-of-bounds std::vector access.
  • The root cause was the regression test corrupting UltraCircuitBuilder::real_variable_index with resize(9). That violates builder invariants, so the static analyzer aborted before ComponentsChecker could report the intended UNCONSTRAINED error.
  • Reworks the fixture to compare the full ACIR circuit against a valid synthesized circuit that omits the ACIR witnesses, and adds the checker message to the expected-type assertion for easier future diagnosis.

Notes

The linked aztec-claude run 30190267425 is a separate stale scheduled workflow copy; aztec-claude#2041 already carries that schedule guard. The real current debug-build failure is the canonical aztec-packages run above.

Testing

  • cmake --preset debug
  • cmake --build --preset debug --target acir_components_check_tests -j$(nproc)
  • ./build-debug/bin/acir_components_check_tests --gtest_filter=AcirComponentsCheckTest.DetectsUnconstrainedWitnesses
  • ./build-debug/bin/acir_components_check_tests
  • NATIVE_PRESET=debug barretenberg/cpp/scripts/run_test.sh acir_components_check_tests AcirComponentsCheckTest.DetectsUnconstrainedWitnesses

Created by claudebox · group: slackbot · Slack thread

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jul 25, 2026
@AztecBot
AztecBot force-pushed the cb/fix-bb-debug-acir-components-test branch from 611e51c to aca63f7 Compare July 26, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant