fix(php-transformer): preserve empty destination anchors as native links - #2372
Merged
Merged
Conversation
Session: ses_f11c14a11ffez3apmkPOyV3Ecm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2367. Lower childless whitespace-only anchors with a safe destination onto the existing native RichText paragraph host instead of treating them as unsupported loss. Preserve the actual link, CSS hitbox and accessible attributes; do not discard duplicate links or add platform-specific predicates. Media-bearing links retain their existing lowering.
Verification
Reviewer checks
Run composer --working-dir=php-transformer test:canonical. Install declared dependencies in php-transformer/tools/visual-parity and run node tests/empty-destination-anchor.mjs. Reimport Crosby with a current paired SSI consumer; prior importer revisions still calling removed destinationSignature are incompatible with current producer API.
Execution evidence and AI assistance
OpenAI gpt-6.1-sol via OpenCode implemented this scoped change through Homeboy Cook cook-detached-e0b0b45b-af2d-49e4-bb56-449be5684416. Orchestrator independently reviewed the diff, ran browser verification and fresh imports, and published under Chris Huber direction. Homeboy recorded replacement gate proof for its watchdog interruption. Final publication occurred outside Homeboy after finalize-pr rejected evidence.summary scalar formatting; retained runtime transcripts, exact package provenance and live import reports remain anchored to #2367.