fix(php-transformer): size source-filled synthetic figures to container - #2350
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause and fix
The Lake Country Players About banner source image fills both axes of its
.section-background. WordPress imports it as an editablecore/imagewrapped in a synthetic figure; that extra figure sizes fromaspect-ratio:1440/562and its height, shrinking the image to 1521px inside a 1600px desktop container and overflowing to 1614px inside a 390px mobile container. The PHP transformer now marks only synthetic figures whose source image has explicit 100% width and height, then gives that marker a low-specificitywidth:100%support rule. Source height, aspect ratio and object-fit remain intact; authored figures and fixed/one-axis images do not qualify.Tracks #2347. This draft is not full-site visual or editor-save acceptance.
Verification
cook-detached-b9132bb1-769c-4fb9-939c-23cbb75c9dc5, candidate attempt...-attempt-1-c41dcb79: Homeboy promoted the PHP patch and its authoritative canonical gate passed after the gate no-progress budget was raised to 900s. A read-only local canonical run also passed after merging the latest trunk. The initial Cook gate timed out after 300s of no structured progress although the suite was still running; this was a gate budget, not a PHP assertion failure.cook-detached-87ad3076-8cee-4d74-8a98-1a5bd316c857produced a TypeScript preserve-DOM change in the wrong renderer. It was rejected before publication; the user-facing SSI paired package uses the PHP transformer. Homeboy recovery finalization rejected the PHP candidate after a base merge changed its recorded tree. Chris Huber explicitly authorized isolated direct finalization; commit, push, and this PR occurred outside Homeboy. Both Cook run artifacts and the rejected attempt are linked from Size synthetic full-bleed image figures to their authored container #2347.AI assistance
GPT-6 Sol (OpenAI) via Homeboy/OpenCode authored the PHP patch. GPT-6 Sol via direct OpenCode confirmed the owning pipeline, rejected the wrong-layer patch, reviewed the candidate, verified it against current trunk, and prepared this draft. Chris Huber directs site acceptance and retains landing authority.