fix(php-transformer): retain authored canvas effect on import - #2346
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source → portable capture → editable WordPress
DLA #458 ships an independently authored, verified portable runtime for the LIQUID BONSAI capture. On first import SSI+BE correctly refused the authored canvas JS target because native conversion discarded
data-blocks-engine-canvas-effect. After repairing that, the compiler exposed a hidden clock config marker as a runtime island; after lowering it, source/WordPress comparison exposed a further mismatch: WordPress put clock date and running-since text in native paragraphs inside addressable wrappers, while the authored portable config correctly targets the wrappers. The prior view scripts refused to animate wrappers with children rather than touching the editable leaf.Generic fixes
data-blocks-engine-motion-stepsanddata-blocks-engine-live-clockJSON markers into their existing editable generated companion blocks and recognize their exact saved marker DOM as a native runtime contract rather than an island.Fresh end-to-end proof
npm run build:dev-package -- --blocks-engine-path <this clean branch> --output-dir <proof-dir>with SSI8a8200dc4446, BEd52c7f4dfd1bsucceeded via Homeboy review. Fresh Studio import of the authored standalone portable capture into a distinct WordPress site (/Users/chubes/Studio/liquidbonsai-portable-native-final-20260929) compiled 33 blocks, zero fallback / runtime islands / content loss / runtime dependency failures, with native canvas + motion-sequence + live-clock blocks automatically lowered from the portable HTML. No manual block insertion or original source script was used.comparewithout--candidate.Refs #2293 and DLA #425.
AI disclosure: GPT-6 Sol via OpenCode traced both actual runtime contract failures and addressable-wrapper text loss, implemented generic native block projection and leaf animation, built/ran a fresh paired SSI import, exercised Gutenberg save/edit/replay, and verified live source/capture/WordPress parity. Chris Huber directs acceptance. Issue-linked direct worktree uses the previously authorized fallback after Homeboy Cook admission blocked; verification/finalization remain outside Homeboy.