fix(php-transformer): preserve direct labels on captured choices - #2345
Merged
Merged
Conversation
Session: ses_f126349ceffej6tyaT72QH83mX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve a source
<label>directly preceding a linked visible combobox, hidden captured panel, and native select as one field label in the form plan. The four-sibling relationship is bounded, and explicitfor, wrapping, and ARIA labels keep precedence.Fixes #2340.
Verification
form-adjacent-source-choice.php, the canonical HTML-to-blocks contract and the WordPress site-plan contract passed. Homeboy Cookcook-detached-0b5a75f9-cecf-4ebc-8827-d4dbb0efcdc8passed its declared gate.0029570bb; runa3fd8f4b1e63c165b65a40d2d7d1b2d7d077a747e55393b04c9573f8482570e7) materialized 10 pages withquality_pass=trueand zero fallback, content loss or invalid blocks. Playwright at 390, 768 and 1440px found exactly the source Contact labels Preferred Contact and Service of Interest in the editable Jetpack form; the form retains two select fields and responsive geometry.Review
Validate the bounded direct-sibling association and its context deduplication. Keep draft pending CI and merged-revision import verification; do not infer full Base44 CRM migration from the public frontend.
AI assistance: OpenAI GPT-6 Sol via OpenCode authored the change through Homeboy and reviewed source and test diffs, a fresh Studio/WordPress paired import, and Chromium label geometry. Chris Huber directs merge and customer acceptance.