fix(php-transformer): apply the native lightbox to gallery card triggers - #1853
Merged
Merged
Conversation
A gallery thumbnail's trigger usually wraps the image and a caption overlay, so it is handled as a card-link wrapper and never reached the bare image-link path. The href was propagated onto the image, leaving a thumbnail that navigates away to the full-size file. Recognize the trigger on the wrapper too and opt its images into core's native lightbox instead of propagating the link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1848, which only reached a bare
<a><img></a>.A real gallery thumbnail wraps the image and a caption overlay:
Because the anchor has mixed content it is handled as a card-link wrapper, so #1848's check never ran and the href was propagated onto the image — leaving a thumbnail that navigates away to the full-size file.
Recognize the trigger on the wrapper as well, and opt its unlinked images into core's native lightbox instead of propagating the link.
Caught by measuring the re-imported page after #1848 landed: all 12 About Me figures still rendered an anchor and none had lightbox markup.
Test plan
php php-transformer/tests/unit/image-lightbox-link-projection.php(14 assertions, including an ordinary card link that must keep propagating its destination)image-carrier-hidden-label,button-link-dispatcher,media-text-pattern,cover-patternphp php-transformer/tests/contract/run.phpAI assistance: grok-4.6 via OpenCode. Caught by verifying the re-imported page rather than trusting the unit fixture.