Unify button dispatch onto ButtonsPattern - #1841
Merged
Merged
Conversation
Route ButtonLinkDispatcher through ButtonAnchorPattern/ButtonPattern, delete duplicate wrapped-button preservation, and back ButtonPatternContext and ButtonLinkDispatchContext with StyleResolver, SourceDom, and existing collaborators. Fixes #1833 AI assistance: xAI grok-4.6 via OpenCode. Chris Huber directed the work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1833
One emitter:
ButtonsPattern+ButtonSignalClassifier. Registry wrappers stay.ButtonLinkDispatcher.convertAnchor/convertButtongo throughrecognizePatternsforButtonAnchorPattern/ButtonPatternfirst. Leftovers are only non-button (logo, image-from-anchor, paragraph host, link wrapper, runtime island).requiresWrappedButtonPreservationon the dispatcher is gone;ButtonsPatternowns it.ButtonElementConverterkeeps search-cluster omit and image-carrier group; genericconvertButtonusesButtonsPattern.ButtonLinkDispatchContextandButtonPatternContexttake StyleResolver, SourceDom, runtime islands, and other existing objects instead of closures. No new Context bags.ButtonStyleResolveris not merged withGeneratedBlockStyleProjector.Verified:
composer testinphp-transformer/(311 parity fixtures).AI assistance
xAI grok-4.6 via OpenCode implemented this change. Chris Huber directed the work.