Update CMS micro-app locator after Shadow DOM removal - #89
Open
IvanRadnevQA wants to merge 27 commits into
Open
Conversation
This reverts commit 7220112.
This reverts commit 9ed7926.
… of 8px margin for more accurate visual tests
PLT-2665 removed the Shadow DOM boundary from apps/shell and renamed data-shadow-host to data-micro-app. PageMap.cmsShadowRoot now queries the new attribute and returns the container Div directly, since there is no shadow root left to unwrap.
n1xan
reviewed
Aug 28, 2026
| var chromeOptions = new ChromeOptions(); | ||
| addDriverOptions(chromeOptions); | ||
| addDriverCapabilities(chromeOptions); | ||
| chromeOptions.addArguments("--proxy-bypass-list=news-tracker-sockets.api.staging.sportal365.com"); |
Collaborator
There was a problem hiding this comment.
Project-specific urls cannot be merged into the framework - maybe you should keep them in the fork.
n1xan
reviewed
Aug 28, 2026
| var chromeHeadlessOptions = new ChromeOptions(); | ||
| addDriverOptions(chromeHeadlessOptions); | ||
| chromeHeadlessOptions.setAcceptInsecureCerts(true); | ||
| chromeHeadlessOptions.addArguments("--proxy-bypass-list=news-tracker-sockets.api.staging.sportal365.com"); |
n1xan
reviewed
Aug 28, 2026
| import solutions.bellatrix.web.services.App; | ||
| import solutions.bellatrix.web.services.ComponentCreateService; | ||
|
|
||
| public abstract class PageMap { | ||
|
|
Collaborator
There was a problem hiding this comment.
these are also looking are project specifics - do you have a Base Page map in the Sportal tests where you can move these?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLT-2665 removed the Shadow DOM boundary from apps/shell and renamed
data-shadow-host to data-micro-app. PageMap.cmsShadowRoot now queries the
new attribute and returns the container Div directly, since there is no
shadow root left to unwrap.