Skip to content

Missing timeout propagation in Automaton::Determinize #3

Description

@davisjam

The API Automaton::Determinize accepts a timeout parameter.

  1. FWIW this parameter is in milliseconds. It would be nice to document that.
  2. The timeout is not propagated recursively when the call to TryDecompose succeeds and d.Determinize() is called. So a regex consisting of a large disjunction exhibits exponential (?) behavior and the requested timeout is ignored.

I can open a PR if interested. The patch seems simple -- add the timeout to the recursive call.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions