Repository navigation
Keep loopback locators of discovered readers - #446
Open
torkeldanielsson wants to merge 1 commit into
Open
torkeldanielsson wants to merge 1 commit into
torkeldanielsson wants to merge 1 commit into
Conversation
Converting an RtpsReaderProxy into the ReaderProxy stored in the discovery database dropped loopback_unicast_locators, so a reader advertising only loopback unicast locators, such as CycloneDDS bound to lo without multicast, matched but never received data.
torkeldanielsson
marked this pull request as ready for review
October 2, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a bug when building a simulator of the Unitree G1 - for some reason I got no messages on loopback. This solved it.
Reproduced on macOS using
hello_world_publisherand CycloneDDS limited to localhost.I want to be open that this was found and fixed with AI assistance, but this text is written by me - a real human, and I have looked over the code.