Skip to content

chore: Update supported languages list#162

Open
anysoftkeyboard-bot wants to merge 1 commit into
mainfrom
chore/update-languages
Open

chore: Update supported languages list#162
anysoftkeyboard-bot wants to merge 1 commit into
mainfrom
chore/update-languages

Conversation

@anysoftkeyboard-bot

Copy link
Copy Markdown
Member

This PR updates the list of supported Wikipedia languages based on the latest statistics.

@anysoftkeyboard-bot

anysoftkeyboard-bot commented May 31, 2026

Copy link
Copy Markdown
Member Author

The PR title must be prefixed with '[LLM]' as required by project guidelines. Furthermore, the PR description is missing mandatory 'What' and 'Why' summaries, the agent's name, and the associated issue number.

@anysoftkeyboard-bot anysoftkeyboard-bot left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data update is a straightforward refresh of Wikipedia language statistics that accurately reflects the latest data without impacting logic or architecture. While there are minor metadata and localization issues, the core changes are sound and approved.

@anysoftkeyboard-bot anysoftkeyboard-bot left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR violates mandatory metadata formatting guidelines for AI Agents (missing [LLM] prefix and agent name) and contains hardcoded English strings that violate the project's localization policy.

@anysoftkeyboard-bot anysoftkeyboard-bot left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR fails to follow mandatory naming and description guidelines for AI Agents and violates localization policies by hardcoding language names in English in an auto-generated file.

@anysoftkeyboard-bot anysoftkeyboard-bot left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR violates AI-generated contribution guidelines regarding title and description formatting and introduces localization technical debt by hardcoding language names in English in a generated file.

Detailed Inline Feedback (Fallback)

  • app/src/main/java/com/anysoftkeyboard/janus/app/util/SupportedLanguages.kt (15-2782): The 'name' field for each SupportedLanguage is hardcoded in English, violating the project's localization policy. These should be resolved dynamically (e.g., using Locale(code).getDisplayName()) or managed via string resources. Since this file is generated, the fix should be implemented in scripts/update_languages.py to prevent recurring technical debt.
  • scripts/update_languages.py (113): The comment states that the languages are sorted 'alphabetical by code', but the implementation on line 128 actually sorts by 'name'. The comment should be updated to reflect the actual sorting logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants