Repository navigation
Always show the current year in the footer copyright - #1
Merged
Merged
Conversation
The Compose theme already renders the build year server-side and ships an updateDate() IIFE meant to refresh it client-side, but that code assigns year.innerHTML (the number) instead of yearEl.innerHTML — a silent no-op. Combined with deployments having stalled in 2023, the live site shows (C) 2023 forever. - assets/js/custom.js: override the theme's placeholder custom.js (bundled last) with a corrected year updater so stale builds self-correct. - config/_default/params.toml: fix AnimeEffectDevs typo in footer author. - .github/workflows/hugo.yml: publish the built site to the gh-pages branch (the configured Pages source) so changes actually ship; drop the unused dart-sass step and deploy via Actions artifact.
p-yukusai
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The live site shows
© 2023 AnimeEffectDevsand never updates.Root cause (three layers)
gh-pagesbranch (a fossil build), and the
hugo.ymlworkflow onmainhas zero runsever — it deploys via
actions/deploy-pages, which requires the Pages source tobe set to GitHub Actions, which it isn't. So nothing newer ever shipped.
updateDate()was supposed to make the year stale-proof:innerHTMLon the numeric variable — a silent no-op in sloppy mode.Verified in a browser: the footer year never changes even when the bundle runs.
config/_default/params.toml:AnimeEffectDevs→AnimeEffectsDevs(rendered next to the year in the footer).Changes
assets/js/custom.js(new) — overrides the theme's placeholderassets/js/custom.js, which Hugo concatenates last intojs/bundle.js. Sets thefooter year to the client's current year on every load, so even a stale build
or cached page displays the correct year.
config/_default/params.toml— fix the author-name typo..github/workflows/hugo.yml— publish the built site to thegh-pagesbranch (the current Pages source), so merges actually deploy without any
settings change. Also: build on PRs (deploy skipped), drop the unused
dart-sass-embeddedstep (the extended binary's libsass compiles the themefine), harden the build with
--gcand the production base URL.Verification
© 1999, the footer renders© 2026after load on both the homepage and/about/(the footer partial is cached, the fix is bundle-level and page-agnostic).Notes for reviewers
{{ now.Year }}in the theme's footer is kept as-is; the JS fixcovers the gap between builds. No theme files were modified (site-level
override only, so theme module updates stay safe).
copyright = 'AnimeEffectsDevs'inconfig.tomlonly feeds the RSS<copyright>element and is left untouched.