Repository navigation
fix(amazonq): require approval of the configuration that an MCP registry server starts with - #3068
Draft
laileni-aws wants to merge 3 commits into
Draft
laileni-aws wants to merge 3 commits into
laileni-aws wants to merge 3 commits into
Conversation
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
laileni-aws
force-pushed
the
fix/mcp-registry-consent
branch
from
November 17, 2026 04:23
d635c1f to
26f0035
Compare
…try server starts with Install from the MCP registry now shows the command, arguments, environment variables, URL and headers of the server before it installs the server. A registry server asks for approval before it starts with a configuration that the user has not approved, including once for a server that was installed before this change. The registry sync asks before it replaces an approved server, and it does not reinstall a server that the user turned off. The consent prompt shows the package index of a server, and the URLs in its command without a user name or password. Adds tests.
…apes The consent prompt of an MCP server shows control, format, private use and unassigned characters, the braille blank and lone surrogates in the command line, the names and the package index as \u escapes, after it shortens them. The review of a registry server configuration also escapes private use and unassigned characters and the braille blank. The registry prompt says that Save and a reinstall ask again. Adds tests of the registry prompt after a version change and of an install whose approval cannot be recorded.
laileni-aws
changed the base branch from
feature/security-fixes-v2
to
feature/laileni-fixes
November 18, 2026 20:38
laileni-aws
force-pushed
the
fix/mcp-registry-consent
branch
from
November 18, 2026 20:38
72c6cb9 to
aafe980
Compare
Harden MCP registry synchronization and server consent handling: - Gate the version re-check on the registry marker the loader keeps, so a new registry version is re-checked instead of skipped. - Show the full command and values in the registry consent prompt, which offers no separate view-configuration action. - Serialize approval-store reads and writes so concurrent server starts do not drop an approval. - Bound how long a background sync waits for a consent answer, and remember an unanswered prompt for the session so it is not reopened. - Match package-index environment variables case-insensitively, include the uv and pip variables, and show each URL in a multi-URL value without its user name or password. - Preserve the user environment, headers, request timeout, enabled tools and always-allow tools when a registry server is reinstalled at a new version. Adds unit tests for each behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.