Repository navigation
fix(amazonq): keep memory bank and agent config writes inside the workspace folder - #3066
Draft
laileni-aws wants to merge 4 commits into
Draft
laileni-aws wants to merge 4 commits into
laileni-aws wants to merge 4 commits into
Conversation
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
laileni-aws
force-pushed
the
fix/workspace-folder-boundary
branch
from
November 17, 2026 04:23
55f3b6f to
ff71f00
Compare
…kspace folder The memory bank cleanup and the agent config migration of a workspace folder now write only when the path, after symbolic links are followed, is inside the workspace folder. Otherwise, or when the path cannot be resolved, they write nothing and log a warning. Every migration call now names the agent config that it writes. Adds tests.
…pace folders Checks that the migration writes nothing when the links of the workspace agent config cannot be resolved, that each workspace folder is checked against its own agent config, and that the global agent config is still written through a linked global agents folder.
laileni-aws
changed the base branch from
feature/security-fixes-v2
to
feature/laileni-fixes
November 18, 2026 20:38
laileni-aws
force-pushed
the
fix/workspace-folder-boundary
branch
from
November 18, 2026 20:38
7bf9b2d to
fd7ae3c
Compare
saveAgentConfig and saveServerSpecificAgentConfig now check, before writing, that the config path stays inside a workspace folder after symbolic links are followed, through the same isInsideFolder helper the migration path uses, and skip the write with a warning otherwise. The global agent config stays exempt. This matches the containment the migration writers already apply, so a server add, remove, or permission change follows the same rule. Adds tests for the save path.
- Throw instead of returning when an agent config save is refused, so the caller reports it - Check where a server is saved before an add, an edit, a removal or a permission change changes anything, and stay on the form with the reason when the save is refused - Refuse a workspace agent config that is also reachable under another name, and a global migration of a path that is not the global agent config - Compare the global agent config path with isSamePath, and move isInsideFolder to toolShared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.