Support objects in expressions - #1777
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5a4dacc to
5c9c571
Compare
2fb14e2 to
ee69ba5
Compare
4d6544b to
4908de3
Compare
4908de3 to
2a553d2
Compare
2a553d2 to
ab5d0b1
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
…to support-objects-in-expressions # Conflicts: # src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs # test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt
ivarne
left a comment
There was a problem hiding this comment.
Ikke noe stort å bemerke her heller 👍
|



Important
This pull request is stacked upon #1769, which should be merged first.
Description
This pull request adds support for objects in expressions, along with an
objectfunction for creating an object. Here is an overview of the changes:objectfunction inExpressionEvaluator. Because of the complexity of the function, I created a separate class namedObjectFunctionEvaluatorfor evaluating the function.ExpressionValue. Most of the code did already exist, hiding in comments.Here is the corresponding change in App frontend: Altinn/altinn-studio#18982
Related Issue(s)
Verification
Documentation
Summary by CodeRabbit
@objectexpression function to create objects from alternating key/value arguments.objectconstruction and object/list lookup scenarios.