Repository navigation
feat(i18n): add en and zh to shared texts and the conversation screen - #183
Merged
Merged
Conversation
…rsation screen The tab bar, error screens, sheets, start-up failures, Host error texts and permission preset names now have English and Simplified Chinese next to the Japanese. The conversation screen and its picker read their texts from web/src/features/conversation/messages.ts, and errors thrown in web/src/dsh are made in the page language.
This was referenced Oct 22, 2026
Owner
Author
|
独立レビュー(自動)の結果です。 判定:直してからマージ 指摘(優先度順)
確認済み
|
The English and Chinese start-up failure now says that the M3E screen may not support this DSH version, as the Japanese does. The permission preset names and descriptions follow the Japanese text instead of the stock DSH wording, and the steer failure says the message cannot interrupt the running operation. The rejection reasons in interactions-store.ts go back to fixed Japanese and interactionErrorMessages is removed, because docs/design/11-i18n.md keeps those texts out of the dictionaries: they are returned to the DSH requester and are not shown on the page.
docs/design/11-i18n.md asks each translation PR to add its new terms to docs/i18n/glossary.md. The rows link to docs/i18n/terms/shell.md for the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of the English and Simplified Chinese rollout (Issue #78). The shared texts (tab bar, error screens, sheets, start-up failures, Host errors, permission preset names) were in dictionaries without translations, the conversation screen and its picker still wrote Japanese inline, and several
web/src/dshmodules threw Japanese errors that can reach the screen. Until the last PR enables the languages, the page stays Japanese.Scope
en/zhforbootMessages,errorMessages,shellMessages,overlayMessages,markdownMessages(web/src/app/messages.ts),remoteErrorMessages,permissionPresetMessages(web/src/dsh/messages.ts).navigationErrorMessages,serviceErrorMessagesused bysession-navigation.ts,conversation-selection.ts,session.ts,services.ts; the texts are made withcurrentLocale()when the error is thrown.interactions-store.tskeeps its fixed Japanese rejection reasons, asdocs/design/11-i18n.mddecides, because they go back to the DSH requester.web/src/features/conversation/messages.tsforConversationScreen.tsx,ConversationPicker.tsx,conversation-choices.ts.app/router.ts: its developer error is English (never shown).docs/i18n/terms/shell.md; the main terms are also rows indocs/i18n/glossary.md.Tradeoffs
Blast radius
No visible change: Japanese strings are identical.
tests/11-shared-messages.test.tsnow expects these catalogs to be translated instead of untranslated.Verification
pnpm typecheck,pnpm test(1,459 tests, 1,457 pass, 2 existing skips),git diff --checkpass.tests/00-i18n-shell.test.tschecks the remote error texts, preset names and conversation choices in English and Chinese.Refs #78