Skip to content

[foreignexchange] Code generation: update services and models - #1791

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/foreignexchange
Open

AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/foreignexchange

Conversation

@AdyenAutomationBot

@AdyenAutomationBot AdyenAutomationBot commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the foreignexchange service.

Adyen/adyen-openapi@45520ee

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner September 23, 2026 15:26

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Foreign Exchange API service to the SDK, adding the RatesApi class for currency exchange calculations along with its corresponding models, typings, and serialization logic. The review feedback highlights a minor formatting issue where the generated models.ts file is missing a trailing newline, suggesting a configuration update to the generator to ensure consistency.

export * from "./rateType"

// serializing and deserializing typed objects
export * from "./objectSerializer" No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The generated model file is missing a trailing newline. According to the repository's general rules, all generated model files in src/typings/ should consistently include a trailing newline. Please configure the generator to ensure a trailing newline is always appended to the generated files.

Suggested change
export * from "./objectSerializer"
export * from "./objectSerializer"
References
  1. Ensure generated model files (e.g., in src/typings/) consistently include a trailing newline, preferably by configuring the generator rather than applying manual fixes to individual files.

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/foreignexchange branch 5 times, most recently from a39e290 to dc7982e Compare October 1, 2026 13:22

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant