Skip to content

[transfers] Code generation: update services and models - #1790

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/transfers
Open

AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/transfers

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the transfers service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner September 23, 2026 13:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the generated transfer SDK models, adding new properties and enum values such as networkVariant for issued cards, ReversalReceived for transfer modifications, usAchCorrectionReasonCode for network reasons, and foreign exchange types (FxSell, FxBuy). Feedback highlights a code generation discrepancy where TransferCategoryData.NetworkVariantEnum is registered in the serializer but the corresponding model file was not updated, as well as a missing trailing newline in networkReason.ts.

"Transfer.TypeEnum",
"TransferCategoryData.PriorityEnum",
"TransferCategoryData.TypeEnum",
"TransferCategoryData.NetworkVariantEnum",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The enum TransferCategoryData.NetworkVariantEnum is added to enumsMap, but the corresponding file src/typings/transfers/transferCategoryData.ts was not updated in this pull request. This indicates a discrepancy in the code generation where a dead or missing enum reference is registered in the serializer.

UkFpsReturnReasonCode = 'ukFpsReturnReasonCode',
UsAchReturnReasonCode = 'usAchReturnReasonCode'
UsAchReturnReasonCode = 'usAchReturnReasonCode',
UsAchCorrectionReasonCode = 'usAchCorrectionReasonCode'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The generated file networkReason.ts is missing a trailing newline. Please ensure generated model files consistently include a trailing newline, preferably by configuring the generator rather than applying manual fixes to individual files.

References
  1. Ensure generated model files (e.g., in src/typings/) consistently include a trailing newline, preferably by configuring the generator rather than applying manual fixes to individual files.

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/transfers branch 3 times, most recently from 8bcc1a9 to 69f4e09 Compare September 28, 2026 08:22

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant