[transfers] Code generation: update services and models - #1790
AdyenAutomationBot wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the generated transfer SDK models, adding new properties and enum values such as networkVariant for issued cards, ReversalReceived for transfer modifications, usAchCorrectionReasonCode for network reasons, and foreign exchange types (FxSell, FxBuy). Feedback highlights a code generation discrepancy where TransferCategoryData.NetworkVariantEnum is registered in the serializer but the corresponding model file was not updated, as well as a missing trailing newline in networkReason.ts.
| "Transfer.TypeEnum", | ||
| "TransferCategoryData.PriorityEnum", | ||
| "TransferCategoryData.TypeEnum", | ||
| "TransferCategoryData.NetworkVariantEnum", |
There was a problem hiding this comment.
The enum TransferCategoryData.NetworkVariantEnum is added to enumsMap, but the corresponding file src/typings/transfers/transferCategoryData.ts was not updated in this pull request. This indicates a discrepancy in the code generation where a dead or missing enum reference is registered in the serializer.
| UkFpsReturnReasonCode = 'ukFpsReturnReasonCode', | ||
| UsAchReturnReasonCode = 'usAchReturnReasonCode' | ||
| UsAchReturnReasonCode = 'usAchReturnReasonCode', | ||
| UsAchCorrectionReasonCode = 'usAchCorrectionReasonCode' |
There was a problem hiding this comment.
The generated file networkReason.ts is missing a trailing newline. Please ensure generated model files consistently include a trailing newline, preferably by configuring the generator rather than applying manual fixes to individual files.
References
- Ensure generated model files (e.g., in
src/typings/) consistently include a trailing newline, preferably by configuring the generator rather than applying manual fixes to individual files.
8bcc1a9 to
69f4e09
Compare
69f4e09 to
cdb4770
Compare
This PR contains the automated changes for the
transfersservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.