Skip to content

Simagic: set the end stop to the rotation whenever the rotation changes - #25

Merged
Adiakys merged 1 commit into
mainfrom
fix/simagic-end-stop
Nov 13, 2026
Merged

Adiakys merged 1 commit into
mainfrom
fix/simagic-end-stop

Conversation

@Adiakys

@Adiakys Adiakys commented Nov 13, 2026

Copy link
Copy Markdown
Owner

For #22 (left open until it is confirmed on the hardware).

What was wrong

On v0.3.3-rc.1 the rotation of an Alpha EVO Sport changes without errors, but raising it only changes the number shown: lowering from 900° to 540° works, raising back to 900° still stops the wheel at 540°. Opening SimPro2 restores it.

In simagic-ff the rotation (max_angle) and the end stop (angle_lock, "End stop angle" in the advanced settings) are separate, and the wheel stops at the narrower of the two. The base most likely narrows the end stop with a lower rotation but never widens it with a higher one, while SimRig wrote only max_angle. SimPro2 sets both from its profile.

What changed

  • Simagic Base::write: after a rotation change, the end stop is set to the same value, rotation first since simagic-ff keeps the end stop within it. Skipped when the driver has no angle_lock. A change refused with the wheel outside the new rotation touches neither.
  • "End stop angle" help: "Set to the rotation whenever the rotation changes."
  • docs/architecture.md: why the end stop follows the rotation.

For the reviewer

  • A narrower end stop is still possible: it is set after the rotation and lasts until the rotation changes again. Following the rotation only when the end stop was at its edge would leave the reporter's state (rotation 900°, end stop 540°) stuck.
  • How the real base handles the end stop is inferred from the report, not confirmed on hardware.
  • New end to end test the_end_stop_follows_the_rotation (fails without the change). cargo fmt --check, clippy -D warnings and cargo test --workspace pass.

@Adiakys Adiakys self-assigned this Nov 13, 2026
@Adiakys Adiakys added the bug Something isn't working label Nov 13, 2026
@Adiakys Adiakys linked an issue Nov 13, 2026 that may be closed by this pull request
8 of 9 tasks
@Adiakys
Adiakys merged commit e7b65bb into main Nov 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Hardware] Simagic Simagic Alpha EVO Sport

1 participant