Repository navigation
Simagic: set the end stop to the rotation whenever the rotation changes - #25
Merged
Merged
Conversation
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #22 (left open until it is confirmed on the hardware).
What was wrong
On v0.3.3-rc.1 the rotation of an Alpha EVO Sport changes without errors, but raising it only changes the number shown: lowering from 900° to 540° works, raising back to 900° still stops the wheel at 540°. Opening SimPro2 restores it.
In simagic-ff the rotation (
max_angle) and the end stop (angle_lock, "End stop angle" in the advanced settings) are separate, and the wheel stops at the narrower of the two. The base most likely narrows the end stop with a lower rotation but never widens it with a higher one, while SimRig wrote onlymax_angle. SimPro2 sets both from its profile.What changed
Base::write: after a rotation change, the end stop is set to the same value, rotation first since simagic-ff keeps the end stop within it. Skipped when the driver has noangle_lock. A change refused with the wheel outside the new rotation touches neither.docs/architecture.md: why the end stop follows the rotation.For the reviewer
the_end_stop_follows_the_rotation(fails without the change).cargo fmt --check,clippy -D warningsandcargo test --workspacepass.