.toml config file auto-update from testbench + minor bug fix - #46
Open
YuxuanHan0326 wants to merge 1 commit into
Open
Conversation
2) Extend config_utils to configure HBM_M_Prefetch_Amount with validation (positive multiple of MLEN), and add HLEN, BROADCAST_AMOUNT, MATRIX_SRAM_SIZE, VECTOR_SRAM_SIZE support 3) Integrate config_utils into ffn/attn/linear/rms/elementwise_add tests so VLEN/MLEN/BLEN/HBM_M_Prefetch_Amount update plena_settings.toml automatically (other dependent HW params still require manual updates in the TOML) 4) Remove hardcoded row/stride defaults in check_mem; require explicit row_dim from comparison_params.json to restore accuracy when VLEN/MLEN changes - TODO: precision settings (exp_width/man_width) still fixed 5) Add reset_plena_config to restore plena_settings.toml from plena_settings.default.toml 6) Add / updated CLI arguments to ffn/attn/linear/rms/elementwise_add tests (defaults unchanged; existing just targets still work) 7) Add elementwise_add testbench (latency works; accuracy verification pending) 8) Fix elementwise_add_asm V_ADD_VV operand formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1) Clean up unused imports in attn_test.py
2) Extend config_utils to configure HBM_M_Prefetch_Amount with validation (positive multiple of MLEN), and add HLEN, BROADCAST_AMOUNT, MATRIX_SRAM_SIZE, VECTOR_SRAM_SIZE support
3) Integrate config_utils into ffn/attn/linear/rms/elementwise_add tests so VLEN/MLEN/BLEN/HBM_M_Prefetch_Amount update plena_settings.toml automatically (other dependent HW params still require manual updates in the TOML)
4) Remove hardcoded row/stride defaults in check_mem; require explicit row_dim from comparison_params.json to restore accuracy when VLEN/MLEN changes
5) Add reset_plena_config to restore plena_settings.toml from plena_settings.default.toml
6) Add / updated CLI arguments to ffn/attn/linear/rms/elementwise_add tests (defaults unchanged; existing just targets still work)
7) Add elementwise_add testbench (latency works; accuracy verification pending) 8) Fix elementwise_add_asm V_ADD_VV operand formatting