Repository navigation
feat(opencode): add bounded native V2 observer - #373
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
777genius
left a comment
777genius
left a comment
There was a problem hiding this comment.
Local Claude Opus 5.5 focused follow-up: all six original findings are addressed; one additional P3 concerns eviction activity classification. No new P1/P2. Native recovery evidence is still in progress.
777genius
left a comment
777genius
left a comment
There was a problem hiding this comment.
Local Claude Opus 5.5 final focused review found one narrow P3: retain gate-blocked terminal work while an inbox admission remains. Earlier findings stay addressed; no P1/P2.
777genius
left a comment
777genius
left a comment
There was a problem hiding this comment.
Local Claude Code / Claude Opus 5.5 final follow-up at 27be62a.
All actionable findings from the four review rounds are addressed (8 total across the two PRs). The final focused model review returned no remaining findings. This is technical code review, not publication or merge approval.
Maintainer verification: 69 SDK tests and typecheck, five plugin tests and bundle build pass. Before/after regressions distinguish all recovery and eviction fixes; the strengthened interruption test fails if its guard is removed. Native same-session recovery passed on 1.18.33, 2.0.0 and 2.0.21, including queue plus interrupt, dismiss, reject and provider failure. Actual private D-Bus calls remained generic, silent and action-free.
Provenance: extended recovery matrices ran at product 153cab3 / SDK b6f6c94; installed-artifact checks after the next eviction fix ran at 31bd651 / SDK 8e651b8. Final exact candidate 2a15a95 / SDK 27be62a passed installed completion on all three native versions and current-V2 managed reload. The extended matrices were not all rerun on final SHA. SDK tarball bytes match committed source and the product lock integrity.
Remaining release gates: SDK 0.2.0 registry publication with the exact integrity, a clean registry install reproducing the bundle, and remaining platform CI on final source. Product PR stays draft. No package published and no PR merged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 61.11% 61.26% +0.14%
==========================================
Files 1377 1381 +4
Lines 73220 73527 +307
==========================================
+ Hits 44748 45043 +295
- Misses 22249 22258 +9
- Partials 6223 6226 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…382) Preserve the public V1/V2 factories and original PR #373 ancestry while adding shared native provenance, bounded cancellation and reader lifecycle checks. Independent GPT-6.1 high review accepted exact head 01f7fce. All 38 current-head checks and the additional review status succeeded; 148 SDK tests and genuine packed public consumers passed. Newer main changes are source-disjoint. Installed Agent Notifications qualification remains a separate checkpoint; no package or release is published. Refs 777genius/agent-notifications#105
OpenCode V2 uses native execution and inbox events that the V1 observer cannot interpret. Add
createV2Observerwhile preservingcreateObserverand its V1 contract. Bound retained metadata and actual host calls, fence stale results, verify ownership and suppress child sessions. Inconclusive ownership can recover on fresh work; eviction preserves live or buffered owned work and reports unavoidable capacity loss.Validation: 69 SDK tests and TypeScript checks pass. Eight new regression cases fail on their previous implementations and pass after fixes; the strengthened interruption test also fails if its guard is removed. The exact package tarball matches committed source and was consumed by native notification checks on 1.18.33, 2.0.0 and 2.0.21 on Linux amd64.
Local Claude Code / Claude Opus 5.5 review comments and fixes are recorded on this PR. The final follow-up found no remaining actionable defect.
Version 0.2.0 is an unpublished candidate. Publication and registry integrity verification require a separate authorized release action. Consumer integration: 777genius/agent-notifications#294 (draft until dependency publication and clean registry qualification).