Repository navigation
feat(opencode): add qualified native clock sampling - #295
Merged
Merged
Conversation
Add a bounded read-only clock helper and boot/domain-qualified samples for original native event admission. Preserve existing journal clock authority; Windows uses precise wall sampling without coarse fallback. Five-platform packaged qualification and notification admission integration remain pending.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Compare the actual class90 boot identity ABI and precise counter against independent native calls. Retain the original whole-snapshot assertion and log bounded failure predicates without native identifiers.
Bind QueryInterruptTimePrecise to the documented realtime API contract. Retain strict boot identity and VOID pointer-output checks; report contract loading and export availability independently.
This was referenced Oct 1, 2026
777genius
added a commit
that referenced
this pull request
Oct 4, 2026
Install one OpenCode notification plugin that selects the stock V1 or V2 observer. Preserve the original checkpoint history from #295, #298, #299, #300, #303 and #308. Independent GPT-6.1 high reviews accepted the final source and installer integration. Installed business checks passed on Linux ARM64, Windows and real macOS ARM64 for both versions. Linux AMD64 TUI checks passed. One-shot run delivery remains best effort; native Intel desktop E2E remains unproved, and this merge does not publish a release. Refs #105 Refs #301 Refs #302 Refs #309 Refs #320 Related #336 Related #337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original OpenCode event age cannot be checked from wall time alone. This adds a bounded read-only
opencode-clockhelper with boot/domain-qualified nanosecond intervals for Linux, Darwin and Windows. Windows resolves the precise interrupt-time export through the documented realtime API-set contract and uses precise wall time with no coarse fallback; unsupported or invalid authority fails closed. Existing notification journal behavior is preserved.This is a prerequisite for dual-version notification admission. It does not yet wire the helper into the SDK/plugin or establish the five-platform packaged E2E matrix.
Validation: independent GPT-6.1 high review; exact integrated clock and full journal tests passed as an unprivileged user in fresh private TEST temporary roots; isolated Linux clock CLI dispatch passed on the same source; worker vet and cross-compilation passed. Historical root/temp environment failures are retained and explained, with no test skips or protection changes. Cross-compilation is not native-platform qualification.
The first native Windows run exposed a missing Kernel32 export on both Go matrix cells, while the strict boot ABI and precise wall checks passed. The repaired head
6602b0674b4c1041ae971008f60b84fedd178b74bindsapi-ms-win-core-realtime-l1-1-1.dll, with separate load/export diagnostic predicates. Independent review, full unprivileged Linux journal/event tests and both Windows test-binary compilations passed for that exact two-file change. Native Windows CI on the repaired head is pending.Related baseline: #294.