Skip to content

A three-by-one issue solution PR - #147

Closed
tacc-tacc wants to merge 3 commits into
5j9:mainfrom
tacc-tacc:main
Closed

A three-by-one issue solution PR#147
tacc-tacc wants to merge 3 commits into
5j9:mainfrom
tacc-tacc:main

Conversation

@tacc-tacc

Copy link
Copy Markdown
Contributor

Let's talk bout three problems I've been adressing today:

  1. fixed section heading parsing: If you have comments before or after your section title, the header remains valid. This isn't what happens in current version. Modified regex and added the comment wildcard (\0) to be detected on the parsing. Added two additional tests to verify.
  2. a solution for the nested link problem: A nested link is invalid unless we are talinkg about an image link. Therefore, in [[a|[[b]]]], [[b]] is the link while the outer brackets will be ignored. On the other hand, in [[File:a.jpg|[[b]]]] both inner and outer brackets must be taken into account. What I did? just wls_append a link if and only if it starts with "File:" or "Image:" OR there are no new link begginings inside ([[). Of course I'd extend this to every language but I don't know where I can find a database with all the equivalences between site namespaces and aliases. I think it's fine for now to leave this as such.
  3. add pycache to gitignore, and I think isn't very professional to leave .vscode exposed on repository. There might be other Python stuff that might be convenient to add too.

If there isn't any opposition, let there be merge.

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7e85ffc) to head (8c67f70).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         2269      2270    +1     
=========================================
+ Hits          2269      2270    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@5j9

5j9 commented Jul 31, 2026

Copy link
Copy Markdown
Owner

merged and released as v1.0.3

@5j9 5j9 closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants