Conversation
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Raises the minimum PHP version to 8.2 and tests the plugin through PHP 8.5.
composer.json(withconfig.platform.phpset to 8.2), the plugin header,readme.txt, and the README.WP_ENV_PHP_VERSIONfollows the matrix, so wp-env runs the suite on each version.testVersion 8.2-8.5) and PHPStan (level 2,phpVersion8.2 to 8.5). New Composer scripts:lint,lint:compat,phpstan.10up/phpcs-composer^3.0.1,phpcompatibility/php-compatibility10.0.0-alpha2,phpstan/phpstan^2.1,szepeviktor/phpstan-wordpress^2.0,phpunit/phpunit^9.6.doctrine/instantiatoris removed.shivammathur/setup-phpis bumped to v2.37.2 in the PHPUnit and E2E workflows.rest_prepare_{$post_type}is registered withadd_filter, sinceprepare_links()returns the response.RelatedEntitiesdocblocks type the relationship asPostToPost|PostToUser.@varannotations inDeletedItemsname$p2u_table.Closes #130
How to test the Change
composer installcomposer lint:compatexits with no errors.composer phpstanreports no errors.WP_ENV_PHP_VERSION=8.5 npm run test:setup && npm run test:phppasses. Repeat with8.2.Follow-ups
phpcompatibility/php-compatibilityis pinned to10.0.0-alpha2. Move to the stable 10.0.0 release once it ships.Changelog Entry
Credits
Props @s3rgiosan
Checklist: