Skip to content

Fix handling nil actions #5

Description

@0Tech
          The `fixActions` method initializes `PreActions` and `PostActions` if they are nil. This approach might hide underlying issues with proposal creation. Re-evaluate if this should be handled upstream or if there's a more robust way to ensure action integrity.

Originally posted by @coderabbitai[bot] in #2 (comment)

Adding e2e test for x/escrow would reveal the current verification of the message including actions has implications. In order to allow empty actions, it's necessary to update the protocol.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions