You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5927aae
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(widgets): extract Bar._render_borders for the shared border preamble
The identical left/right border resolution (resolve callables, subtract
their visible length from width) was copy-pasted across five bar __call__
methods. Extract it into Bar._render_borders(progress, data, width) ->
(left, right, remaining_width) and call it from Bar, BouncingBar,
MultiRangeBar and JobStatusBar (all Bar subclasses).
GranularBar descends from AutoWidthWidgetBase (not Bar) so it can't reach
the helper; rather than hoisting border concerns onto a shared width-widget
base (a responsibility smell affecting widgets that have no borders) or
changing any MRO, its copy is kept with an explanatory comment.
Behavior-preserving: widget render output byte-identical, full suite +
render goldens pass, widgets.py at 100% branch coverage.
0 commit comments