ci: align staticcheck pins across Go workflows

Author: arjunkomath

.github/workflows/cli-ci.yml

@@ -43,7 +43,7 @@ jobs:
         run: go vet ./...
 
       - name: Install staticcheck
-        run: GOBIN=$PWD/.bin go install honnef.co/go/tools/cmd/staticcheck@latest
+        run: GOBIN=$PWD/.bin go install honnef.co/go/tools/cmd/staticcheck@v0.7.0
 
       - name: Staticcheck
         run: ./.bin/staticcheck ./...

.github/workflows/updater-ci.yml

@@ -45,7 +45,7 @@ jobs:
         run: go vet ./...
 
       - name: Install staticcheck
-        run: GOBIN=$PWD/.bin go install honnef.co/go/tools/cmd/staticcheck@latest
+        run: GOBIN=$PWD/.bin go install honnef.co/go/tools/cmd/staticcheck@v0.7.0
 
       - name: Staticcheck
         run: ./.bin/staticcheck ./...

agent/internal/traefik/static.go

@@ -15,6 +15,7 @@ const (
 	metricsEntryPointAddr = "127.0.0.1:9100"
 )
 
+// Whole-number buckets must be ints to match yaml.v3's decoded types.
 var prometheusLatencyBuckets = []interface{}{
 	0.005,
 	0.01,

agent/internal/traefik/static_test.go

@@ -53,11 +53,12 @@ func TestEnsurePrometheusMetricsConfigIsStable(t *testing.T) {
 	if err != nil {
 		t.Fatalf("failed to marshal config: %v", err)
 	}
-	if err := yaml.Unmarshal(data, &config); err != nil {
+	var roundTripped map[string]interface{}
+	if err := yaml.Unmarshal(data, &roundTripped); err != nil {
 		t.Fatalf("failed to unmarshal config: %v", err)
 	}
 
-	if ensurePrometheusMetricsConfig(config) {
+	if ensurePrometheusMetricsConfig(roundTripped) {
 		t.Fatal("expected second call to be stable")
 	}
 }