Skip to content

Commit cd04609

Browse files
authored
Merge pull request #302 from techulus/fix/preview-comment-duplicate-status
Remove duplicate preview comment status
2 parents 8bddfb7 + 0f8ef77 commit cd04609

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

‎web/lib/preview-deployments.ts‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,12 @@ async function updatePreviewPullRequestComment(input: {
8484
input.previewUrl
8585
? `**Preview:** [Open preview](${input.previewUrl})`
8686
: "**Preview:** No public URL configured",
87-
"",
88-
`<sub>${escapeGitHubCommentText(input.description.substring(0, 500))}</sub>`,
87+
...(input.state === "failure"
88+
? [
89+
"",
90+
`<sub>${escapeGitHubCommentText(input.description.substring(0, 500))}</sub>`,
91+
]
92+
: []),
8993
].join("\n");
9094
await upsertGitHubPullRequestComment(
9195
input.installationId,

‎web/tests/preview-deployments.test.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,9 @@ describe("preview service cloning", () => {
404404
}),
405405
);
406406
expect(mocks.upsertGitHubPullRequestComment).toHaveBeenCalledTimes(2);
407+
expect(
408+
mocks.upsertGitHubPullRequestComment.mock.calls[0]?.[4],
409+
).not.toContain("<sub>");
407410
expect(mocks.upsertGitHubPullRequestComment).toHaveBeenLastCalledWith(
408411
101,
409412
"acme/app",

0 commit comments

Comments
 (0)