Repository navigation
Sorted remotes for deterministic builds
#16901
Replies: 1 comment
|
Yes — this is a real bug, your one-liner fixes it, and there is direct precedent for exactly this kind of change being merged. I reproduced the non-determinism empirically: six consecutive Why the order is non-deterministic (source trace, master @
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hiya, first time potentially contributing to such a huge project, so I'd rather ask instead of imposing weird ideas, opening a PR, etc.
The reason is, I've currently Ko for SvelteKit in the works, i.e. an image builder. And, in order to make it deterministic, the
remoteswould need to be sorted.Is there a need or want for such a feature (or tool)? There seems to be some want for deterministic behaviour and builds according to some discussions.
The PR would be really small, one addition to
packages/kit/src/core/generate_manifest/index.js:Then replace
remotesinwith
sorted_remotesPlus, three tests for
packages/kit/src/core/generate_manifest/index.spec.jsto verify/ascertain/make sure and changeset.All reactions