diff --git a/pkg/monitors/pingdomtransaction/pingdom-transaction-monitor.go b/pkg/monitors/pingdomtransaction/pingdom-transaction-monitor.go index 508ccc95..ea1b6ca2 100644 --- a/pkg/monitors/pingdomtransaction/pingdom-transaction-monitor.go +++ b/pkg/monitors/pingdomtransaction/pingdom-transaction-monitor.go @@ -220,9 +220,7 @@ func (service *PingdomTransactionMonitorService) addConfigToTransactionCheck(tra if providerConfig.SendNotificationWhenDown > 0 { transactionCheck.SendNotificationWhenDown = ptr.Int64(providerConfig.SendNotificationWhenDown) } - if providerConfig.Paused { - transactionCheck.Active = ptr.Bool(!providerConfig.Paused) - } + transactionCheck.Active = ptr.Bool(!providerConfig.Paused) if len(providerConfig.Tags) > 0 { transactionCheck.Tags = providerConfig.Tags } diff --git a/pkg/monitors/pingdomtransaction/pingdom-transaction-monitor_test.go b/pkg/monitors/pingdomtransaction/pingdom-transaction-monitor_test.go index 423edf94..cf46ddf1 100644 --- a/pkg/monitors/pingdomtransaction/pingdom-transaction-monitor_test.go +++ b/pkg/monitors/pingdomtransaction/pingdom-transaction-monitor_test.go @@ -107,6 +107,36 @@ func TestGetSecretFromTemplate(t *testing.T) { } } +func TestAddConfigPausedActive(t *testing.T) { + tests := []struct { + name string + paused bool + expectedActive bool + }{ + {name: "paused true -> inactive", paused: true, expectedActive: false}, + {name: "paused false -> active", paused: false, expectedActive: true}, + } + + for _, tc := range tests { + t.Run(tc.name, func(t *testing.T) { + service := PingdomTransactionMonitorService{} + transactionCheck := &pingdomNew.CheckWithoutID{} + monitor := models.Monitor{ + Name: "test", + URL: "https://google.com", + Config: &endpointmonitorv1alpha1.PingdomTransactionConfig{ + Paused: tc.paused, + }, + } + + service.addConfigToTransactionCheck(transactionCheck, monitor) + + assert.Assert(t, transactionCheck.Active != nil, "Active must always be set") + assert.Equal(t, *transactionCheck.Active, tc.expectedActive) + }) + } +} + func TestReplaceSecrets(t *testing.T) { // Create a fake clientset clientset := fake.NewSimpleClientset()