From b6e8b14a96cfe2054edbf60ef73af45909af1b8c Mon Sep 17 00:00:00 2001 From: Audric Ackermann Date: Mon, 13 Jul 2026 16:43:37 +0200 Subject: [PATCH] fix: fix tests for donate_appeal tests --- tests/automation/cta_donations.spec.ts | 4 ++-- tests/automation/enforce_localized_str.spec.ts | 8 ++++---- tests/automation/utilities/send_media.ts | 10 +--------- tests/localization/lib | 2 +- 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/tests/automation/cta_donations.spec.ts b/tests/automation/cta_donations.spec.ts index f94a6e1..03adee3 100644 --- a/tests/automation/cta_donations.spec.ts +++ b/tests/automation/cta_donations.spec.ts @@ -14,8 +14,8 @@ import { async function verifyDonateCTAShows(window: Page) { await checkCTAStrings( window, - tStripped('finalAppeal'), - tStripped('finalAppealDescription'), + tStripped('ongoingAppeal'), + tStripped('ongoingAppealDescription'), [tStripped('readMoreCapital')], ); } diff --git a/tests/automation/enforce_localized_str.spec.ts b/tests/automation/enforce_localized_str.spec.ts index ad600f2..ddb7d10 100644 --- a/tests/automation/enforce_localized_str.spec.ts +++ b/tests/automation/enforce_localized_str.spec.ts @@ -291,12 +291,12 @@ function getExpectedStringFromKey( return 'Quit'; case 'donateSessionAppealTitle': return 'Please Read: A Personal Appeal From Cofounder of Session Chris McCabe'; - case 'finalAppealDescription': - return "Your donations have helped, but the Session Technology Foundation (STF) has only received enough funding to support critical operations until the 8th of July. Development has been paused, and without additional funding the STF will shut down, resulting in Session being removed from the app stores and essential services going offline. Please help us secure Session's future."; + case 'ongoingAppealDescription': + return 'When it looked like Session might disappear, you stepped up. Your donations have given the Session Technology Foundation (STF) enough funding to enable a small team of contributors to maintain the app. Right now, the focus is keeping Session secure, stable, and online. Your donations can help support Session in this critical time. Additional donations may allow for more developers to be hired and help deliver the features needed to advance Session faster.'; case 'readMoreCapital': return 'Read More'; - case 'finalAppeal': - return 'Our Final Appeal: Session is shutting down in 90 days'; + case 'ongoingAppeal': + return 'New Hope for Session'; case 'donateSessionAppealDescription': return 'Eight years ago, Session was founded with a mission to restore your privacy. Today, Session faces a funding shortage which puts its very survival at risk. If you’ve ever found value in Session or its mission, please give me a moment of your time and read this appeal.'; case 'donateSessionAppealReadMore': diff --git a/tests/automation/utilities/send_media.ts b/tests/automation/utilities/send_media.ts index afb277d..3ec5cf2 100644 --- a/tests/automation/utilities/send_media.ts +++ b/tests/automation/utilities/send_media.ts @@ -4,7 +4,6 @@ import { tStripped } from '../../localization/lib'; import { sleepFor } from '../../promise_utils'; import { testLinkTitle } from '../constants/variables'; import { Conversation, Global, Settings } from '../locators'; -import { isRunningOnDevNet } from '../setup/open'; import { MediaType } from '../types/testing'; import { waitForMessageStatus } from './message'; import { @@ -15,7 +14,6 @@ import { clickOnWithText, controlOrMetaFor, pasteIntoInput, - waitForLoadingAnimationToFinish, waitForTestIdWithText, waitForTextMessage, } from './utils'; @@ -144,13 +142,7 @@ export const sendLinkPreview = async (window: Page, testLink: string) => { tStripped('linkPreviewsFirstDescription'), ); await clickOnWithText(window, Global.confirmButton, tStripped('enable')); - if (!isRunningOnDevNet()) { - // when on devnet, often we don't even see the loading spinner - await waitForLoadingAnimationToFinish( - window, - Global.loadingSpinner.selector, - ); - } + await waitForTestIdWithText(window, 'link-preview-image'); await waitForTestIdWithText(window, 'link-preview-title', testLinkTitle); await clickOnElement({ diff --git a/tests/localization/lib b/tests/localization/lib index ceffc44..f824751 160000 --- a/tests/localization/lib +++ b/tests/localization/lib @@ -1 +1 @@ -Subproject commit ceffc446039c90ea1b85b9d6c83df9f282113045 +Subproject commit f824751eba28e98843e082c08672393224e6b939