From df1854850d6d89482e7b0fbc660e5e7eaa6d92f6 Mon Sep 17 00:00:00 2001 From: hinriksnaer Date: Sat, 9 May 2026 18:31:37 -0400 Subject: [PATCH 1/2] fix: fix vllm commit flag --- scripts/devinstall_vllm.sh | 6 +++--- scripts/devsetup.sh | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/devinstall_vllm.sh b/scripts/devinstall_vllm.sh index bacbd9c..bf990a5 100755 --- a/scripts/devinstall_vllm.sh +++ b/scripts/devinstall_vllm.sh @@ -164,9 +164,9 @@ install_whl() { if [ -n "${PIP_VLLM_EXTRA_INDEX_URL:-}" ]; then echo "Using the specified index, $PIP_VLLM_EXTRA_INDEX_URL" pip_install_args+=("--extra-index-url" "$PIP_VLLM_EXTRA_INDEX_URL") - elif [ -n "${VLLM_COMMIT:-}" ]; then - echo "Using the build from commit $VLLM_COMMIT ..." - pip_install_args+=("--extra-index-url" "${pip_vllm_index_url_base}/${VLLM_COMMIT}") + elif [ -n "${PIP_VLLM_COMMIT:-}" ]; then + echo "Using the build from commit $PIP_VLLM_COMMIT ..." + pip_install_args+=("--extra-index-url" "${pip_vllm_index_url_base}/${PIP_VLLM_COMMIT}") elif command -v uv &>/dev/null; then if [ -n "${UV_TORCH_BACKEND:-}" ]; then echo "Using the specified uv backend, $UV_TORCH_BACKEND" diff --git a/scripts/devsetup.sh b/scripts/devsetup.sh index 2326fe6..1581dc3 100755 --- a/scripts/devsetup.sh +++ b/scripts/devsetup.sh @@ -48,7 +48,7 @@ declare -a SAVE_VARS=( "TRITON_GITREF" "USE_CCACHE" "UV_TORCH_BACKEND" - "VLLM_COMMIT" + "PIP_VLLM_COMMIT" "VLLM_GITREF" "WAYLAND_DISPLAY" "WORKSPACE" From c0e60ebb4f39e910966d02f3f6c96e37a27961c4 Mon Sep 17 00:00:00 2001 From: hinriksnaer Date: Sat, 9 May 2026 18:34:51 -0400 Subject: [PATCH 2/2] fix: preserve user-specified PIP_VLLM_EXTRA_INDEX_URL for nightly installs --- scripts/devinstall_vllm.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/devinstall_vllm.sh b/scripts/devinstall_vllm.sh index bf990a5..470018a 100755 --- a/scripts/devinstall_vllm.sh +++ b/scripts/devinstall_vllm.sh @@ -155,7 +155,7 @@ install_whl() { case "$pip_build" in release) ;; nightly) - PIP_VLLM_EXTRA_INDEX_URL="${pip_vllm_index_url_base}/nightly" + PIP_VLLM_EXTRA_INDEX_URL="${PIP_VLLM_EXTRA_INDEX_URL:-${pip_vllm_index_url_base}/nightly}" ;; esac