Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Consider BaseplateError exceptions with code=5xx an error for span accounting #606

Description

@spladug

We don't generally consider IDL-specified Thrift exceptions as span failures (since they're generally equivalent to a 4xx in HTTP terms -- they're part of a valid response rather than an indication the service failed). However, when we create BaseplateError exceptions with explicit 5xx error codes we should count those as service failures and set success=False in span accounting.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions