Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Should kafka message pump be outside server span? #599

Description

@spladug

https://github.com/reddit/baseplate.py/blob/develop/baseplate/frameworks/queue_consumer/kafka.py#L77

This sleep is inside a server span so it's subject to timeouts. That doesn't seem right since it's kinda on the outside of the event loop.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions