Convert Doctrine annotations from phpdoc-parser nodes, remove StaticDoctrineAnnotationParser (#8881)

Author: ondrejmirtes

phpstan.neon

@@ -300,7 +300,6 @@ parameters:
             message: '#Function "property_exists\(\)" cannot be used/left in the code#'
             paths:
                 - src/NodeNameResolver/NodeNameResolver.php
-                - src/BetterPhpDocParser/NodeDecorator/DoctrineAnnotationDecorator.php
 
         -
             identifier: symplify.forbiddenFuncCall
@@ -361,8 +360,3 @@ parameters:
             paths:
                 - tests/Issues/
                 - tests/PhpParser/NodeTraverser/StopTraverseOnTypeChange/Class_
-
-        # known types
-        -
-            identifier: varTag.nativeType
-            path: src/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser.php

rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/keep_single_quoted.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Fixture;
+
+use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericAnnotation;
+
+/**
+ * @GenericAnnotation("sample", itemOperations='yes')
+ */
+final class SkipSingleQuotedKeyValue
+{
+}
+
+?>

rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/keep_single_quoted2.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Fixture;
+
+use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericSingleImplicitAnnotation;
+
+/**
+ * @GenericSingleImplicitAnnotation('/')
+ */
+final class SkipSingleQuotedValue
+{
+}
+
+?>

rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/keep_single_quoted_key_value.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Fixture;
+
+use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericSingleImplicitAnnotation;
+
+/**
+ * @GenericSingleImplicitAnnotation('"foo"')
+ */
+final class SkipSingleQuotedWithDoubleQuotes
+{
+}
+
+?>

rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/skip_single_quoted_key_value.php.inc

@@ -14,8 +14,10 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Property;
+use PHPStan\PhpDocParser\Ast\PhpDoc\InvalidTagValueNode;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
+use Rector\BetterPhpDocParser\PhpDocParser\ClassAnnotationMatcher;
 use Rector\Enum\ClassName;
 use Rector\NodeAnalyzer\PropertyFetchAnalyzer;
 use Rector\NodeNameResolver\NodeNameResolver;
@@ -31,7 +33,8 @@ public function __construct(
         private NodeComparator $nodeComparator,
         private PropertyFetchAnalyzer $propertyFetchAnalyzer,
         private PhpDocInfoFactory $phpDocInfoFactory,
-        private PhpAttributeAnalyzer $phpAttributeAnalyzer
+        private PhpAttributeAnalyzer $phpAttributeAnalyzer,
+        private ClassAnnotationMatcher $classAnnotationMatcher
     ) {
     }
 
@@ -79,13 +82,33 @@ public function resolveFromClass(
     private function hasModelTypeCheck(Class_|Property $node, string $modelType): bool
     {
         $phpDocInfo = $this->phpDocInfoFactory->createFromNode($node);
-        if ($phpDocInfo instanceof PhpDocInfo && $phpDocInfo->hasByAnnotationClass($modelType)) {
+        if ($phpDocInfo instanceof PhpDocInfo && ($phpDocInfo->hasByAnnotationClass(
+            $modelType
+        ) || $this->hasInvalidAnnotation($phpDocInfo, $node, $modelType))) {
             return true;
         }
 
         return $this->phpAttributeAnalyzer->hasPhpAttribute($node, $modelType);
     }
 
+    /**
+     * An annotation with arguments that are not valid, e.g. @JMS\Type('string)
+     */
+    private function hasInvalidAnnotation(PhpDocInfo $phpDocInfo, Class_|Property $node, string $modelType): bool
+    {
+        foreach ($phpDocInfo->getPhpDocNode()->getTags() as $phpDocTagNode) {
+            if (! $phpDocTagNode->value instanceof InvalidTagValueNode) {
+                continue;
+            }
+
+            if ($this->classAnnotationMatcher->resolveTagFullyQualifiedName($phpDocTagNode->name, $node) === $modelType) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
     private function matchPropertyPromotionCandidate(
         Property $property,
         ClassMethod $constructClassMethod,