Use PHPStan Type::toNativePhpTypeNode() and Type::toPhpDocNode() instead of own type mappers (#8885)

* Use PHPStan Type::toNativePhpTypeNode() instead of mapToPhpParserNode()

Amp-Thread-ID: https://ampcode.com/threads/T-01a179f2-995f-7745-8d8c-4c174ba5c0ce

* Use PHPStan Type::toPhpDocNode() instead of PHPStanStaticTypeMapper

PHPStan now returns phpdoc-parser 2.4's FullyQualifiedNameNode for class
names from Type::toPhpDocNode(), so Rector no longer needs its own
mapToPHPStanPhpDocTypeNode() mappers to tell class names from keywords.
The PHPStanStaticTypeMapper package is removed. StaticTypeMapper keeps
Rector's docblock style (A|B, A[], plain int) on top of toPhpDocNode().

Rector's shortened and aliased object types return a RelativeNameNode.
The name importing and class renaming PHPDoc visitors also handle name
nodes, and code reading the name of a generic or callable type node no
longer assumes an IdentifierTypeNode.

Amp-Thread-ID: https://ampcode.com/threads/T-01a179f2-995f-7745-8d8c-4c174ba5c0ce

Author: ondrejmirtes

UPGRADING.md

@@ -1,3 +1,7 @@
+# Upgrading to the next Rector release
+
+* `TypeMapperInterface::mapToPhpParserNode()` is removed; custom type mappers only map to PHPDoc nodes now. A custom `Type` controls its native declaration by overriding `toNativePhpTypeNode()`.
+
 # Upgrading from Rector 2.2.14 to 2.3
 
 * `FileWithoutNamespace` is deprecated, and replaced by `FileNode` that represents both namespaced and non-namespaced files and allow changes inside

phpstan.neon

@@ -284,11 +284,6 @@ parameters:
             paths:
                 - src/NodeTypeResolver/PHPStan/Type/TypeFactory.php
 
-        # from mapper interface
-        -
-            identifier: return.unusedType
-            message: '#mapToPhpParserNode\(\) never returns PhpParser\\.* so it can be removed from the return#'
-
         # false positive
         -
             identifier: return.unusedType

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/has_property_type.php.inc

@@ -0,0 +1,53 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+final class HasPropertyType
+{
+    /**
+     * @param mixed $data
+     */
+    public function run($data)
+    {
+        if (! isset($data->type)) {
+            return;
+        }
+
+        if ($data->type === 'value') {
+            $this->runData($data);
+        }
+    }
+
+    private function runData($data)
+    {
+    }
+}
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+final class HasPropertyType
+{
+    /**
+     * @param mixed $data
+     */
+    public function run($data)
+    {
+        if (! isset($data->type)) {
+            return;
+        }
+
+        if ($data->type === 'value') {
+            $this->runData($data);
+        }
+    }
+
+    private function runData(object $data)
+    {
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/skip_has_property_type.php.inc

@@ -33,7 +33,7 @@ use stdClass;
 
 final class DifferentUsage {
     /**
-     * @param \stdClass[]|\DateTime[] $items
+     * @param \DateTime[]|\stdClass[] $items
      */
     public function process(array $items): void
     {

rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamArrayDocblockBasedOnCallableNativeFuncCallRector/Fixture/different_usage.php.inc

@@ -33,7 +33,7 @@ use stdClass;
 final class WithArrayFilterAndArrayWalk
 {
     /**
-     * @param string[]|\stdClass[] $items
+     * @param \stdClass[]|string[] $items
      */
     public function process(array $items): void
     {

rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamArrayDocblockBasedOnCallableNativeFuncCallRector/Fixture/with_array_filter_and_array_walk.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector\Fixture;
+
+final class ReturnAnonymousClassAndOther
+{
+    public function action()
+    {
+        if (rand(0, 1)) {
+            return new class {};
+        }
+
+        return new static();
+    }
+}
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector\Fixture;
+
+final class ReturnAnonymousClassAndOther
+{
+    public function action(): object
+    {
+        if (rand(0, 1)) {
+            return new class {};
+        }
+
+        return new static();
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromReturnNewRector/Fixture/return_anonymous_class_and_other.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnUnionTypeRector\Fixture;
+
+final class AnonymousClassAndOtherObject
+{
+    public function run()
+    {
+        if (rand(0,1)) {
+            return new SkipAnonymousClassAndOtherObject();
+        }
+
+        return new class {};
+    }
+}
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnUnionTypeRector\Fixture;
+
+final class AnonymousClassAndOtherObject
+{
+    public function run(): object
+    {
+        if (rand(0,1)) {
+            return new SkipAnonymousClassAndOtherObject();
+        }
+
+        return new class {};
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromReturnNewRector/Fixture/skip_return_anonymous_class_and_other.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnUnionTypeRector\Fixture;
+
+final class AnonymousClassAndOtherObject2
+{
+    public function run()
+    {
+        if (rand(0,1)) {
+            return new SkipAnonymousClassAndOtherObject();
+        }
+
+        $obj = new class {};
+        return $obj;
+    }
+}
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnUnionTypeRector\Fixture;
+
+final class AnonymousClassAndOtherObject2
+{
+    public function run(): object
+    {
+        if (rand(0,1)) {
+            return new SkipAnonymousClassAndOtherObject();
+        }
+
+        $obj = new class {};
+        return $obj;
+    }
+}