Running: qlty coverage publish --validate
WARNING: --validate is deprecated, validation is now enabled by default. Use --no-validate to disable validation
In v2.0.0 a change was made to validate uploaded coverage reports by default.
I have two (very minor) nitpicks relating to this change:
- The README has not yet been updated (still lists the
validate input default value as false).
- Using the action in its default configuration raises the above deprecation warning. It should not raise any warnings.
Background
As a newcomer configuring the action for the first time, I looked through the list of inputs available in the README and saw the validate option listed with a default value of false. Thinking that validation sounded like a good thing, I set validate: true in my workflow.
When I saw the deprecation warning in the job logs, I then removed the validate input and re-ran the workflow. Yet the warning still appeared.
If I'm reading the CHANGELOG entry correctly, it would seem that the CLI was updated to always run validation without --validate being passed.
Yet the corresponding change to the GitHub action toggled the default from false -> true, meaning that it still passes --validate to the CLI.
Suggest that the --validate option be omitted entirely when invoking the CLI (but --validate-file-threshold presumably is still allowed).
In v2.0.0 a change was made to validate uploaded coverage reports by default.
I have two (very minor) nitpicks relating to this change:
validateinput default value asfalse).Background
As a newcomer configuring the action for the first time, I looked through the list of inputs available in the README and saw the
validateoption listed with a default value offalse. Thinking that validation sounded like a good thing, I setvalidate: truein my workflow.When I saw the deprecation warning in the job logs, I then removed the
validateinput and re-ran the workflow. Yet the warning still appeared.If I'm reading the CHANGELOG entry correctly, it would seem that the CLI was updated to always run validation without
--validatebeing passed.Yet the corresponding change to the GitHub action toggled the default from
false->true, meaning that it still passes--validateto the CLI.Suggest that the
--validateoption be omitted entirely when invoking the CLI (but--validate-file-thresholdpresumably is still allowed).