Skip to content

Coverage action: Don't pass --validate flag to CLI #149

@scottohara

Description

@scottohara
Running: qlty coverage publish --validate

WARNING: --validate is deprecated, validation is now enabled by default. Use --no-validate to disable validation

In v2.0.0 a change was made to validate uploaded coverage reports by default.

I have two (very minor) nitpicks relating to this change:

  1. The README has not yet been updated (still lists the validate input default value as false).
  2. Using the action in its default configuration raises the above deprecation warning. It should not raise any warnings.

Background

As a newcomer configuring the action for the first time, I looked through the list of inputs available in the README and saw the validate option listed with a default value of false. Thinking that validation sounded like a good thing, I set validate: true in my workflow.

When I saw the deprecation warning in the job logs, I then removed the validate input and re-ran the workflow. Yet the warning still appeared.

If I'm reading the CHANGELOG entry correctly, it would seem that the CLI was updated to always run validation without --validate being passed.

Yet the corresponding change to the GitHub action toggled the default from false -> true, meaning that it still passes --validate to the CLI.

Suggest that the --validate option be omitted entirely when invoking the CLI (but --validate-file-threshold presumably is still allowed).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions