Skip to content

Fix batch / simple processor instrumentation semantics #8680

Description

@jack-berg

BatchLogRecordProcessor / BatchSpanProcessor / SimpleLogRecordProcessor / SimpleSpanProcessor each call .finish{Signals}(batch.size(), error) after the export has completed.

As @cijothomas notes here, this is wrong. Instead, the processors should call finish immediately after a batch has been submitted to the exporter:

For the SDK Simple and Batching Span Processor a span is considered to be processed already when it has been submitted to the exporter, not when the corresponding export call has finished."

We should fix this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions