fixup!

Author: avivkeller

test/parallel/test-repl-autolibs.js

@@ -0,0 +1,32 @@
+import * as common from '../common/index.mjs';
+import { startNewREPLServer } from '../common/repl.js';
+import assert from 'node:assert';
+import util from 'node:util';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+
+const { output, run } = startNewREPLServer({ useGlobal: true, terminal: false });
+
+// Referencing a builtin by bare name auto-requires it onto the real global,
+// and the value is identity-equal to the normally-required module.
+{
+  output.accumulator = '';
+  await run(['fs']);
+  assert.strictEqual(output.accumulator,
+                     `${util.inspect(require('fs'), null, 2, false)}\n`);
+  assert.strictEqual(globalThis.fs, require('fs'));
+}
+
+// A user-defined global with a builtin's name is NOT overwritten by the
+// auto-require, and the REPL prints the user's value.
+{
+  const val = {};
+  globalThis.url = val;
+  common.allowGlobals(val);
+
+  output.accumulator = '';
+  await run(['url']);
+  assert.strictEqual(output.accumulator, '{}\n');
+  assert.strictEqual(val, globalThis.url);
+}

test/parallel/test-repl-autolibs.mjs

@@ -29,7 +29,19 @@ const { startNewREPLServer } = require('../common/repl');
   replServer.write('.editor\n');
 
   replServer.write('a');
-  replServer.write(null, { name: 'tab' }); // Should not throw
 
-  replServer.close();
+  // Tab completion is asynchronous (it is driven by the inspector), so the
+  // REPL must only be closed once the completion has settled. Closing it while
+  // a completion is still in flight would make the completion callback resume a
+  // closed readline interface and throw `ERR_USE_AFTER_CLOSE`.
+  const originalCompleter = replServer.completer;
+  replServer.completer = common.mustCall((text, cb) => {
+    originalCompleter.call(replServer, text, common.mustCall((...args) => {
+      const result = cb(...args);
+      replServer.close();
+      return result;
+    }));
+  });
+
+  replServer.write(null, { name: 'tab' }); // Should not throw
 }