fix(next-auth): do not assume x-forwarded-proto on server actions - #13492
Open
RealBhupesh wants to merge 1 commit into
Open
RealBhupesh wants to merge 1 commit into
RealBhupesh wants to merge 1 commit into
Conversation
- Add getProtocol() helper to safely derive request protocol - Fallback order: AUTH_URL/NEXTAUTH_URL > x-forwarded-proto header > http in dev / https in prod - Handle comma-separated x-forwarded-proto values (use first value) - Remove @ts-expect-error comments for nullable proto - Add regression tests for missing x-forwarded-proto scenarios Fixes nextauthjs#13388 Co-authored-by: Bhupesh Cholake <realbhupesh@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@cursoragent is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Next.js 16, server actions often omit
x-forwarded-proto.signIn/signOut/update/getSessionpassedheaders.get("x-forwarded-proto")intocreateActionURL, which treats a missing value ashttps. Local HTTP then fails as a maskedConfigurationerror.Fix
Add
getProtocol()with fallback:AUTH_URL/NEXTAUTH_URLorigin, then first hop ofx-forwarded-proto, thenhttpin development/test andhttpsin production. Never passnull.Tests
Unit tests for
getProtocolandsignInwithoutx-forwarded-proto.Fixes #13388