fix: handle expression arg that matches a filename#2714
Open
sjh9714 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes expression arguments that happen to match an existing filename.
What changed
processArgs()regression coverage for.versionwhen a same-named file exists and an input file or stdin follows it..yqexpression files, and explicit path-qualified file args such as./.version.Why
Before this change,
processArgs()skipped expression detection when the first arg existed as a file, soyq '.version' data.ymlcould read.versionas an input file instead of evaluating.versionagainstdata.yml.After this change,
.version data.ymland.version -are parsed as expression plus input, while users can still force file interpretation with./.version.Testing
go test ./cmd -run TestProcessArgs -count=1failed before the production fix with.versionleft in args instead of becoming the expression.go test ./cmd -run TestProcessArgs -count=1go test ./cmd -count=1go test ./...bash ./scripts/devtools.shmake local testgit diff --checkFixes #2477
Note: I used Codex to help inspect the code path and draft the regression test, but I reviewed the final diff and ran the listed verification commands locally.