Multiple issues with NeTEx schema: default value false not supported, deserialization exceptions

[Micovec]

Hello,

I'm trying out this project on commit 62413d4 with xsd from https://github.com/TransmodelEcosystem/NeTEx file xds/NeTEx_publication.xsd and I can't seem to get it to run properly. After a while I always get an exception System.NotSupportedException: 'Getting default value for false. not supported.' in TypeModel:120.

I checked the xsd and it's caused by elements that are of type MultilingualString with default value false.. When I removed that line in netex_framework/netex_reusableComponents/neteq_equipment_version.xsd:151 the exception was the same but this time with false (without the dot). When I removed all of these occurences, it ran fine.

The second issue is that the generated code could not deserialize public NeTEx files from the Czech Central Information System (public transit info in the Czechia): https://portal.cisjr.cz/pub/netex/ files from archive NeTEx_DrahyMestske.zip. SitePathLinkEndStructure class has properties SiteElementRef and EntranceRef that both have XmlElementAttribute attributes with the same element names.

I deleted XmlElementAttributes that had the same element name from SiteElementRef just to see if it was the only issue. It was not. ActivationAssignmentVersionStructure could not be deserialized either. I got an exception: InvalidOperationException: You need to add XmlChoiceIdentifierAttribute to the 'EquipmentRef' member.. In this case I have no idea how to resolve the issue.

I ran the generator with: -t- --sf --nr --nc --uc --oxi --ecl.

xsd.exe craches instantly since the schema has multiple includes which it does not support, lol.

I would take a look at this myself but I don't quite understand xsd and it is going to take some time to understand the codebase of this project. I will try to and will come back when I figure something out.

[Micovec]

Ok, so the default value is schema's invalid attribute value as per mentioned issue.

However the duplication of element names remains.

[Micovec]

I have finally found the culprit. It's properties that have two or more XmlElementAttribute attributes that have set the same Type property.

This is an example of what the generator sometimes outputs and what is problematic:

public class Struct
{
    [XmlElement("SubStruct", Type = typeof(SubStruct))]
    [XmlElement("SubStruct_", Type = typeof(SubStruct))] // Element with the same type but different name; This is the reason XmlSerializer throws an exception
    public SubStruct SubStruct { get; set; }
}

public class SubStruct { }

I will look into the reason why does the generator output this and hopefully I will create a PR fix.

[mganss]

I've pushed a fix for the default value issue but the other issues remain.

If you use the --order flag the code compiles and runs but the deserialized objects are missing some content.
If you use the --separateSubstitutes flag you get other issues with duplicated element names.