Skip to content

[refactor]: Remove git info from property of ComponentProfile #55

Description

@ravut8

Overview

The purpose of this issue is to remove git information from ComponentProfile because issue #6 will add a separate git info which is more detailed and useful in analyzing components. Therefore, we should remove git info from ComponentProfile to ensure better maintainability.

These are 3 places we need to remove vue-scanner.ts

Initial property detail

berryjam/src/vue-scanner.ts

Lines 693 to 697 in 07dc984

dataLastModified: "",
lastModified: "",
created: "",
createdBy: "",
updatedBy: "",

Interface file property

berryjam/src/types.ts

Lines 61 to 65 in 07dc984

created: string;
createdBy: string;
updatedBy: string;
lastModified: string;
dataLastModified: string;

Initial property component

berryjam/src/vue-scanner.ts

Lines 516 to 520 in 07dc984

dataLastModified: "",
lastModified: "",
created: "",
createdBy: "",
updatedBy: "",

There are 2 places to remove from analyze-component-files.spec.ts unit test

  1. dataLastModified: "Fri Apr 28 2023",
    lastModified: "Fri Apr 28 2023",
    created: "2023-04-17T04:04:04.000Z",
    createdBy: "system",
    updatedBy: "system",
  2. dataLastModified: "Fri Apr 28 2023",
    lastModified: "Fri Apr 28 2023",
    created: "2023-04-17T04:04:04.000Z",
    createdBy: "system",
    updatedBy: "system",

Expected Behavior

  • Remove all of them
  • Scan to check that there is no error in exporting components.json
  • Check in components.json that git info is no longer in this JSON file

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that we believe are relatively straightforward to tackle. Good for newcomers.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions