From 4862dba26de94b55cd8b62c82714505bb1b17127 Mon Sep 17 00:00:00 2001 From: U9G Date: Tue, 22 Sep 2026 12:38:21 -0400 Subject: [PATCH] Pass FIELDS to write! by value in generated Visitors Clippy 1.98 adds useless_borrows_in_formatting, which fires on every Visitor the generator writes: `&FIELDS` where `FIELDS` is already a `&[&str]`. Any crate that includes generated code and builds with -Dwarnings fails on it. Fixes #157. --- pbjson-build/src/generator/enumeration.rs | 2 +- pbjson-build/src/generator/message.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pbjson-build/src/generator/enumeration.rs b/pbjson-build/src/generator/enumeration.rs index 3bae939..8951d32 100644 --- a/pbjson-build/src/generator/enumeration.rs +++ b/pbjson-build/src/generator/enumeration.rs @@ -125,7 +125,7 @@ fn write_visitor( {indent} type Value = {rust_type}; {indent} fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {{ -{indent} write!(formatter, "expected one of: {{:?}}", &FIELDS) +{indent} write!(formatter, "expected one of: {{:?}}", FIELDS) {indent} }} {indent} fn visit_i64(self, v: i64) -> std::result::Result diff --git a/pbjson-build/src/generator/message.rs b/pbjson-build/src/generator/message.rs index 0ecaa8d..01be603 100644 --- a/pbjson-build/src/generator/message.rs +++ b/pbjson-build/src/generator/message.rs @@ -710,7 +710,7 @@ fn write_deserialize_field_name( {indent} type Value = GeneratedField; {indent} fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {{ -{indent} write!(formatter, "expected one of: {{:?}}", &FIELDS) +{indent} write!(formatter, "expected one of: {{:?}}", FIELDS) {indent} }} {indent} #[allow(unused_variables)]