forked from openbmc/phosphor-bmc-code-mgmt
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathimage_verify.cpp
More file actions
449 lines (379 loc) · 12.9 KB
/
Copy pathimage_verify.cpp
File metadata and controls
449 lines (379 loc) · 12.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
#include "config.h"
#include "image_verify.hpp"
#include "images.hpp"
#include "utils.hpp"
#include "version.hpp"
#include <fcntl.h>
#include <openssl/err.h>
#include <sys/stat.h>
#include <phosphor-logging/elog-errors.hpp>
#include <phosphor-logging/elog.hpp>
#include <phosphor-logging/lg2.hpp>
#include <xyz/openbmc_project/Common/error.hpp>
#include <cassert>
#include <fstream>
#include <set>
#include <system_error>
namespace phosphor
{
namespace software
{
namespace image
{
PHOSPHOR_LOG2_USING;
using namespace phosphor::logging;
using namespace phosphor::software::manager;
using InternalFailure =
sdbusplus::error::xyz::openbmc_project::common::InternalFailure;
constexpr auto keyTypeTag = "KeyType";
constexpr auto hashFunctionTag = "HashType";
Signature::Signature(const fs::path& imageDirPath,
const fs::path& signedConfPath) :
imageDirPath(imageDirPath), signedConfPath(signedConfPath)
{
fs::path file(imageDirPath / MANIFEST_FILE_NAME);
keyType = Version::getValue(file, keyTypeTag);
hashType = Version::getValue(file, hashFunctionTag);
// Get purpose
auto purposeString = Version::getValue(file, "purpose");
auto convertedPurpose =
sdbusplus::message::convert_from_string<VersionPurpose>(purposeString);
purpose = convertedPurpose.value_or(Version::VersionPurpose::Unknown);
}
AvailableKeyTypes Signature::getAvailableKeyTypesFromSystem() const
{
AvailableKeyTypes keyTypes{};
// Find the path of all the files
std::error_code ec;
if (!fs::is_directory(signedConfPath, ec))
{
error("Signed configuration path not found in the system: {ERROR_MSG}",
"ERROR_MSG", ec.message());
elog<InternalFailure>();
}
// Look for all the hash and public key file names get the key value
// For example:
// /etc/activationdata/OpenBMC/publickey
// /etc/activationdata/OpenBMC/hashfunc
// /etc/activationdata/GA/publickey
// /etc/activationdata/GA/hashfunc
// Set will have OpenBMC, GA
for (const auto& p : fs::recursive_directory_iterator(signedConfPath))
{
if ((p.path().filename() == HASH_FILE_NAME) ||
(p.path().filename() == PUBLICKEY_FILE_NAME))
{
// extract the key types
// /etc/activationdata/OpenBMC/ -> get OpenBMC from the path
auto key = p.path().parent_path();
keyTypes.insert(key.filename());
}
}
return keyTypes;
}
inline KeyHashPathPair Signature::getKeyHashFileNames(const Key_t& key) const
{
fs::path hashpath(signedConfPath / key / HASH_FILE_NAME);
fs::path keyPath(signedConfPath / key / PUBLICKEY_FILE_NAME);
return std::make_pair(std::move(hashpath), std::move(keyPath));
}
bool Signature::verifyFullImage()
{
bool ret = true;
#ifdef WANT_SIGNATURE_VERIFY
// Only verify full image for BMC
if (purpose != VersionPurpose::BMC)
{
return ret;
}
std::vector<std::string> fullImages = {
fs::path(imageDirPath) / "image-bmc.sig",
fs::path(imageDirPath) / "image-hostfw.sig",
fs::path(imageDirPath) / "image-kernel.sig",
fs::path(imageDirPath) / "image-rofs.sig",
fs::path(imageDirPath) / "image-rwfs.sig",
fs::path(imageDirPath) / "image-u-boot.sig",
fs::path(imageDirPath) / "MANIFEST.sig",
fs::path(imageDirPath) / "publickey.sig"};
// Merge files
std::string tmpFullFile = "/tmp/image-full";
utils::mergeFiles(fullImages, tmpFullFile);
// Validate the full image files
fs::path pkeyFullFile(tmpFullFile);
std::string imageFullSig = "image-full.sig";
fs::path pkeyFullFileSig(imageDirPath / imageFullSig);
pkeyFullFileSig.replace_extension(SIGNATURE_FILE_EXT);
// image specific publickey file name.
fs::path publicKeyFile(imageDirPath / PUBLICKEY_FILE_NAME);
ret = verifyFile(pkeyFullFile, pkeyFullFileSig, publicKeyFile, hashType);
std::error_code ec;
fs::remove(tmpFullFile, ec);
#endif
return ret;
}
bool Signature::verify()
{
try
{
bool valid;
// Verify the MANIFEST and publickey file using available
// public keys and hash on the system.
if (!systemLevelVerify())
{
error("System level Signature Validation failed");
return false;
}
bool bmcFilesFound = false;
// image specific publickey file name.
fs::path publicKeyFile(imageDirPath / PUBLICKEY_FILE_NAME);
// Record the images which are being updated
// First check and Validate for the fullimage, then check and Validate
// for images with partitions
std::vector<std::string> imageUpdateList = {bmcFullImages};
valid = checkAndVerifyImage(imageDirPath, publicKeyFile,
imageUpdateList, bmcFilesFound);
if (bmcFilesFound && !valid)
{
return false;
}
if (!valid)
{
// Validate bmcImages
imageUpdateList.clear();
imageUpdateList.assign(bmcImages.begin(), bmcImages.end());
valid = checkAndVerifyImage(imageDirPath, publicKeyFile,
imageUpdateList, bmcFilesFound);
if (bmcFilesFound && !valid)
{
return false;
}
}
// Validate the optional image files.
auto optionalImages = getOptionalImages();
bool optionalFilesFound = false;
bool optionalImagesValid = false;
for (const auto& optionalImage : optionalImages)
{
// Build Image File name
fs::path file(imageDirPath);
file /= optionalImage;
std::error_code ec;
if (fs::exists(file, ec))
{
optionalFilesFound = true;
// Build Signature File name
fs::path sigFile(file);
sigFile += SIGNATURE_FILE_EXT;
// Verify the signature.
optionalImagesValid =
verifyFile(file, sigFile, publicKeyFile, hashType);
if (!optionalImagesValid)
{
error("Image file Signature Validation failed on {IMAGE}",
"IMAGE", optionalImage);
return false;
}
}
}
if (!verifyFullImage())
{
error("Image full file Signature Validation failed");
return false;
}
if (!bmcFilesFound && !optionalFilesFound)
{
error("Unable to find files to verify");
return false;
}
// Either BMC images or optional images shall be valid
assert(valid || optionalImagesValid);
debug("Successfully completed Signature validation.");
return true;
}
catch (const InternalFailure& e)
{
return false;
}
catch (const std::exception& e)
{
error("Error during processing: {ERROR}", "ERROR", e);
return false;
}
}
bool Signature::systemLevelVerify()
{
// Get available key types from the system.
auto keyTypes = getAvailableKeyTypesFromSystem();
if (keyTypes.empty())
{
error("Missing Signature configuration data in system");
elog<InternalFailure>();
}
// Build publickey and its signature file name.
fs::path pkeyFile(imageDirPath / PUBLICKEY_FILE_NAME);
fs::path pkeyFileSig(pkeyFile);
pkeyFileSig.replace_extension(SIGNATURE_FILE_EXT);
// Build manifest and its signature file name.
fs::path manifestFile(imageDirPath / MANIFEST_FILE_NAME);
fs::path manifestFileSig(manifestFile);
manifestFileSig.replace_extension(SIGNATURE_FILE_EXT);
auto valid = false;
// Verify the file signature with available key types
// public keys and hash function.
// For any internal failure during the key/hash pair specific
// validation, should continue the validation with next
// available Key/hash pair.
for (const auto& keyType : keyTypes)
{
auto keyHashPair = getKeyHashFileNames(keyType);
auto hashFunc = Version::getValue(keyHashPair.first, hashFunctionTag);
try
{
// Verify manifest file signature
valid = verifyFile(manifestFile, manifestFileSig,
keyHashPair.second, hashFunc);
if (valid)
{
// Verify publickey file signature.
valid = verifyFile(pkeyFile, pkeyFileSig, keyHashPair.second,
hashFunc);
if (valid)
{
break;
}
}
}
catch (const InternalFailure& e)
{
valid = false;
}
}
return valid;
}
bool Signature::verifyFile(const fs::path& file, const fs::path& sigFile,
const fs::path& publicKey,
const std::string& hashFunc)
{
// Check existence of the files in the system.
std::error_code ec;
if (!(fs::exists(file, ec) && fs::exists(sigFile, ec)))
{
error("Failed to find the Data or signature file {PATH}", "PATH", file);
if (ec)
{
error("Error message: {ERROR_MSG}", "ERROR_MSG", ec.message());
}
elog<InternalFailure>();
}
// Create RSA.
auto publicRSA = createPublicRSA(publicKey);
if (!publicRSA)
{
error("Failed to create RSA from {PATH}", "PATH", publicKey);
elog<InternalFailure>();
}
// Initializes a digest context.
EVP_MD_CTX_Ptr rsaVerifyCtx(EVP_MD_CTX_new(), ::EVP_MD_CTX_free);
// Adds all digest algorithms to the internal table
OpenSSL_add_all_digests();
// Create Hash structure.
auto hashStruct = EVP_get_digestbyname(hashFunc.c_str());
if (!hashStruct)
{
error("EVP_get_digestbynam: Unknown message digest: {HASH}", "HASH",
hashFunc);
elog<InternalFailure>();
}
auto result = EVP_DigestVerifyInit(rsaVerifyCtx.get(), nullptr, hashStruct,
nullptr, publicRSA.get());
if (result <= 0)
{
error("Error ({RC}) occurred during EVP_DigestVerifyInit", "RC",
ERR_get_error());
elog<InternalFailure>();
}
// Hash the data file and update the verification context
auto size = fs::file_size(file, ec);
auto dataPtr = mapFile(file, size);
result = EVP_DigestVerifyUpdate(rsaVerifyCtx.get(), dataPtr(), size);
if (result <= 0)
{
error("Error ({RC}) occurred during EVP_DigestVerifyUpdate", "RC",
ERR_get_error());
elog<InternalFailure>();
}
// Verify the data with signature.
size = fs::file_size(sigFile, ec);
auto signature = mapFile(sigFile, size);
result = EVP_DigestVerifyFinal(
rsaVerifyCtx.get(), reinterpret_cast<unsigned char*>(signature()),
size);
// Check the verification result.
if (result < 0)
{
error("Error ({RC}) occurred during EVP_DigestVerifyFinal", "RC",
ERR_get_error());
elog<InternalFailure>();
}
if (result == 0)
{
error("EVP_DigestVerifyFinal:Signature validation failed on {PATH}",
"PATH", sigFile);
return false;
}
return true;
}
inline EVP_PKEY_Ptr Signature::createPublicRSA(const fs::path& publicKey)
{
std::error_code ec;
auto size = fs::file_size(publicKey, ec);
// Read public key file
auto data = mapFile(publicKey, size);
BIO_MEM_Ptr keyBio(BIO_new_mem_buf(data(), -1), &::BIO_free);
if (keyBio.get() == nullptr)
{
error("Failed to create new BIO Memory buffer");
elog<InternalFailure>();
}
return {PEM_read_bio_PUBKEY(keyBio.get(), nullptr, nullptr, nullptr),
&::EVP_PKEY_free};
}
CustomMap Signature::mapFile(const fs::path& path, size_t size)
{
CustomFd fd(open(path.c_str(), O_RDONLY));
return CustomMap(mmap(nullptr, size, PROT_READ, MAP_PRIVATE, fd(), 0),
size);
}
bool Signature::checkAndVerifyImage(
const std::string& filePath, const std::string& publicKeyPath,
const std::vector<std::string>& imageList, bool& fileFound)
{
bool valid = true;
fileFound = false;
for (auto& bmcImage : imageList)
{
fs::path file(filePath);
file /= bmcImage;
std::error_code ec;
if (!fs::exists(file, ec))
{
valid = false;
break;
}
fileFound = true;
fs::path sigFile(file);
sigFile += SIGNATURE_FILE_EXT;
// Verify the signature.
valid = verifyFile(file, sigFile, publicKeyPath, hashType);
if (!valid)
{
error("Image file Signature Validation failed on {PATH}", "PATH",
bmcImage);
return false;
}
}
return valid;
}
} // namespace image
} // namespace software
} // namespace phosphor